Add missing dependencies to IncludeCategories#745

Merged

Spartan322 merged 1 commit into

fix/clang-format-header-order

May 20, 2026

Spartan322 commented May 20, 2026 •

edited

Loading

Member

Format potentially category-related header includes

Addresses include ordering comments in Move STL-like container headers to core/stl/containers #744

Spartan322 requested a review from a team as a code owner

May 20, 2026 11:52

Spartan322 added bug enhancement topic:codestyle labels

wvpm reviewed

View reviewed changes

src/openvic-simulation/console/ConsoleInstance.cpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/core/memory/SmartPtr.hpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/country/CountryInstance.cpp

wvpm reviewed

View reviewed changes

src/openvic-simulation/country/CountryInstance.hpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/dataloader/Dataloader.cpp

wvpm reviewed

View reviewed changes

src/openvic-simulation/dataloader/NodeTools.cpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/economy/production/ArtisanalProducer.cpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/economy/production/ResourceGatheringOperation.cpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/map/MapDefinition.cpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/map/MapDefinition.cpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/map/ProvinceDefinition.hpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/military/Wargoal.cpp

wvpm reviewed

View reviewed changes

src/openvic-simulation/misc/GameAction.hpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/pathfinding/AStarPathing.hpp

wvpm reviewed

View reviewed changes

src/openvic-simulation/pathfinding/PointMap.cpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/pathfinding/PointMap.hpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/scripts/Condition.cpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/testing/Testing.hpp

wvpm reviewed

View reviewed changes

src/openvic-simulation/types/Colour.hpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/types/Date.hpp

wvpm reviewed

View reviewed changes

src/openvic-simulation/types/Vector.hpp

Spartan322 force-pushed the fix/clang-format-header-order branch from 860df43 to 4a15fd2 Compare

May 20, 2026 12:16

wvpm reviewed

View reviewed changes

src/openvic-simulation/country/CountryInstance.cpp Outdated

Spartan322 force-pushed the fix/clang-format-header-order branch from 4a15fd2 to da8cba9 Compare

May 20, 2026 12:28

wvpm reviewed

View reviewed changes

src/openvic-simulation/population/Pop.hpp Outdated

wvpm reviewed

View reviewed changes

src/openvic-simulation/population/PopsAggregate.cpp

wvpm reviewed

View reviewed changes

src/openvic-simulation/population/PopsAggregate.hpp

wvpm reviewed

View reviewed changes

src/openvic-simulation/GameManager.hpp


          Add missing dependencies to IncludeCategories

ed6c198

Format potentially category-related header includes
Add SortIncludes format option

Spartan322 force-pushed the fix/clang-format-header-order branch from da8cba9 to ed6c198 Compare

May 20, 2026 13:34

wvpm approved these changes

View reviewed changes

wvpm left a comment

Contributor

Nice PR that focuses purely on include ordering.
Only the third party vs openvic lib order is an open question.

Spartan322 merged commit 4f7789a into master

16 checks passed

Spartan322 deleted the fix/clang-format-header-order branch

May 20, 2026 16:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug enhancement topic:codestyle