Skip to content

fix: scope Open Library footer to library pages - #116

Closed
dethan3 wants to merge 3 commits into
Open-Source-Bazaar:mainfrom
dethan3:fix/scope-open-library-footer
Closed

fix: scope Open Library footer to library pages#116
dethan3 wants to merge 3 commits into
Open-Source-Bazaar:mainfrom
dethan3:fix/scope-open-library-footer

Conversation

@dethan3

@dethan3 dethan3 commented Aug 26, 2026

Copy link
Copy Markdown
Member

PR-116 PR-116 PR-116 Powered by Pull Request Badge

Checklist(清单):

  • [×] Labels
  • [×] Assignees
  • [×] Reviewers

Closes #115

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ca43e41-2a9d-4f79-aa69-19d90fe4666d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TechQuery TechQuery left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我当时之所以让你合并两个页脚,是因为我觉得新页脚的整体样式和内容都比以前要好。现在的问题只是个别文案和链接与图书馆强绑定,所以要么做通用化处理,要么给这个组件加几个参数从外面传一些定制内容,而不是又退回两个独立的页脚组件……

@dethan3

dethan3 commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

后续代码更改在 #117

@dethan3 dethan3 closed this Aug 27, 2026
@TechQuery

Copy link
Copy Markdown
Member

后续代码更改在 #117

是 ChatGPT 没法复用已有的 PR 吗?

@dethan3

dethan3 commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

可以复用原有的 PR
ChatGPT 只能从我 Fork 的仓库发起 PR ,但为了便于预览,我选择重新在本地,用原仓库开一个新分支,推送新 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

页脚文案容易让人将“开源市集”误解为图书馆项目

2 participants