fix: scope Open Library footer to library pages - #116
Closed
dethan3 wants to merge 3 commits into
Closed
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TechQuery
requested changes
Aug 26, 2026
TechQuery
left a comment
Member
There was a problem hiding this comment.
我当时之所以让你合并两个页脚,是因为我觉得新页脚的整体样式和内容都比以前要好。现在的问题只是个别文案和链接与图书馆强绑定,所以要么做通用化处理,要么给这个组件加几个参数从外面传一些定制内容,而不是又退回两个独立的页脚组件……
Member
Author
|
后续代码更改在 #117 |
Member
是 ChatGPT 没法复用已有的 PR 吗? |
Member
Author
|
可以复用原有的 PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist(清单):
Closes #115