Skip to content

fix: scope Open Library footer to library pages #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dethan3 wants to merge 3 commits into from
+109 −77
Closed

fix: scope Open Library footer to library pages #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f96bea
fix: restore global site footer
dethan3 Aug 26, 2026
19b7c29
refactor: keep footer within open library
dethan3 Aug 26, 2026
2892d5a
fix: select footer by route
dethan3 Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 19 additions & 76 deletions components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,88 +1,31 @@
import { observer } from 'mobx-react';
import { useContext } from 'react';
import { Col, Container, Nav, Row } from 'react-bootstrap';
import { Image } from 'react-bootstrap';

import { ContactEmail, GitHubURL, WeChatURL } from '../models/configuration';
import { I18nContext } from '../models/Translation';

export const Footer = observer(() => {
const { t } = useContext(I18nContext);
const currentYear = new Date().getFullYear();

return (
<footer className="bg-dark text-light py-4">
<Container fluid="xl" className="px-3">
<Row>
<Col md={4} className="mb-3 mb-md-0">
<h5 className="fw-bold mb-3">{t('open_source_bazaar')}</h5>
<p className="text-light opacity-75 lh-base">{t('footer_description')}</p>
<div className="mt-3">
<a
href={GitHubURL}
className="text-light text-decoration-none me-3 hover-opacity"
target="_blank"
rel="noopener noreferrer"
>
🐱 GitHub
</a>
<a
href={WeChatURL}
className="text-light text-decoration-none me-3 hover-opacity"
target="_blank"
rel="noopener noreferrer"
>
💬 WeChat
</a>
</div>
</Col>
<Col md={3} className="mb-3 mb-md-0">
<h5 className="fw-bold mb-3">{t('quick_links_footer')}</h5>
<Nav className="flex-column">
<Nav.Link
href="/open-library/books"
className="text-light px-0 py-1 text-decoration-none"
>
📖 {t('catalog_footer')}
</Nav.Link>
<Nav.Link
href="/open-library/how-to-borrow"
className="text-light px-0 py-1 text-decoration-none"
>
ℹ️ {t('how_to_borrow')}
</Nav.Link>
</Nav>
</Col>
<Col md={5}>
<h5 className="fw-bold mb-3">{t('contact')}</h5>
<ul className="list-unstyled d-flex flex-column gap-2 text-light opacity-75 mb-0">
<li>📍 {t('community_name')}</li>
<li>📌 {t('community_location')}</li>
<li>
✉️{' '}
<a className="text-light" href={`mailto:${ContactEmail}`}>
{ContactEmail}
</a>
</li>
<li>
💬{' '}
<a
className="text-light"
href={WeChatURL}
target="_blank"
rel="noopener noreferrer"
>
{t('community_name')}
</a>
</li>
</ul>
</Col>
</Row>

<hr className="mt-4 mb-3 border-secondary opacity-25" />

<div className="text-center text-light opacity-75 py-2">
&copy; {new Date().getFullYear()} {t('open_source_bazaar')}. {t('all_rights_reserved')}
</div>
</Container>
<footer className="mw-100 bg-dark text-white">
<p className="text-center my-0 py-3">
<span className="pr-3">
© 2021{currentYear === 2021 ? '' : `-${currentYear}`} {t('open_source_bazaar')}
</span>
<a
className="flex-fill d-flex justify-content-center align-items-center"
href="https://vercel.com/"
target="_blank"
rel="noopener noreferrer"
>
Powered by
<span className="mx-2">
<Image src="/vercel.svg" alt="Vercel Logo" width={72} height={16} />
</span>
</a>
</p>
</footer>
);
});
88 changes: 88 additions & 0 deletions components/open-library/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
import { observer } from 'mobx-react';
import { useContext } from 'react';
import { Col, Container, Nav, Row } from 'react-bootstrap';

import { ContactEmail, GitHubURL, WeChatURL } from '../../models/configuration';
import { I18nContext } from '../../models/Translation';

export const OpenLibraryFooter = observer(() => {
const { t } = useContext(I18nContext);

return (
<footer className="bg-dark text-light py-4">
<Container fluid="xl" className="px-3">
<Row>
<Col md={4} className="mb-3 mb-md-0">
<h5 className="fw-bold mb-3">{t('open_source_bazaar')}</h5>
<p className="text-light opacity-75 lh-base">{t('footer_description')}</p>
<div className="mt-3">
<a
href={GitHubURL}
className="text-light text-decoration-none me-3 hover-opacity"
target="_blank"
rel="noopener noreferrer"
>
🐱 GitHub
</a>
<a
href={WeChatURL}
className="text-light text-decoration-none me-3 hover-opacity"
target="_blank"
rel="noopener noreferrer"
>
💬 WeChat
</a>
</div>
</Col>
<Col md={3} className="mb-3 mb-md-0">
<h5 className="fw-bold mb-3">{t('quick_links_footer')}</h5>
<Nav className="flex-column">
<Nav.Link
href="/open-library/books"
className="text-light px-0 py-1 text-decoration-none"
>
📖 {t('catalog_footer')}
</Nav.Link>
<Nav.Link
href="/open-library/how-to-borrow"
className="text-light px-0 py-1 text-decoration-none"
>
ℹ️ {t('how_to_borrow')}
</Nav.Link>
</Nav>
</Col>
<Col md={5}>
<h5 className="fw-bold mb-3">{t('contact')}</h5>
<ul className="list-unstyled d-flex flex-column gap-2 text-light opacity-75 mb-0">
<li>📍 {t('community_name')}</li>
<li>📌 {t('community_location')}</li>
<li>
✉️{' '}
<a className="text-light" href={`mailto:${ContactEmail}`}>
{ContactEmail}
</a>
</li>
<li>
💬{' '}
<a
className="text-light"
href={WeChatURL}
target="_blank"
rel="noopener noreferrer"
>
{t('community_name')}
</a>
</li>
</ul>
</Col>
</Row>

<hr className="mt-4 mb-3 border-secondary opacity-25" />

<div className="text-center text-light opacity-75 py-2">
&copy; {new Date().getFullYear()} {t('open_source_bazaar')}. {t('all_rights_reserved')}
</div>
</Container>
</footer>
);
});
3 changes: 2 additions & 1 deletion pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import Head from 'next/head';

import { Footer } from '../components/Footer';
import { MainNavigator } from '../components/Navigator/MainNavigator';
import { OpenLibraryFooter } from '../components/open-library/Footer';
import { LibraryNavbar } from '../components/open-library/Navbar';
import { PageContent } from '../components/PageContent';
import { isServer } from '../models/configuration';
Expand Down Expand Up @@ -90,7 +91,7 @@ export default class CustomApp extends App<I18nProps> {
) : (
this.renderSiteFrame(isArticlePage)
)}
<Footer />
{isOpenLibraryPath ? <OpenLibraryFooter /> : <Footer />}
</I18nContext.Provider>
);
}
Expand Down