Skip to content

fix: generalize site footer content - #117

Open
dethan3 wants to merge 7 commits into
mainfrom
fix/generalize-site-footer
Open

fix: generalize site footer content#117
dethan3 wants to merge 7 commits into
mainfrom
fix/generalize-site-footer

Conversation

@dethan3

@dethan3 dethan3 commented Aug 27, 2026

Copy link
Copy Markdown
Member

PR-117 PR-117 PR-117 Powered by Pull Request Badge

Summary

  • parameterize the shared Footer component instead of duplicating it
  • select global or Open Library content from _app.tsx based on the current route
  • preserve the current Open Library footer content and responsive layout
  • restore global-site copyright history and Vercel attribution
  • add Simplified Chinese, Traditional Chinese, and English global footer copy
  • use Next.js client-side links for footer quick links

Context

This follows the reviewer feedback in #116: keep one Footer component and pass route-specific content into it instead of maintaining two independent footer implementations.

Validation

  • pnpm test passed
  • Prettier and git diff --check passed
  • TypeScript and webpack production compilation passed via CI=true NEXT_TELEMETRY_DISABLED=1 pnpm exec next build --webpack
  • full static generation exits during the existing page-data generation phase in the current local environment
  • verified /, /article/about, /open-library, and /open-library/books in a local browser
  • visually checked global and Open Library footers at desktop and mobile widths

Close #115

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e86d61fa-bef9-4062-9dcb-9cee44b803bf


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dethan3

dethan3 commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Responsive design follow-up:

  • desktop Footer now uses three equal-width columns with left / center / right content alignment
  • mobile Footer now has distinct brand, quick-link, contact, and copyright regions
  • quick-link touch targets are 44px high and icon/text columns align consistently
  • tablet layout uses a full-width brand row plus two balanced secondary columns
  • Open Library keeps its existing copy and links while sharing the responsive structure

Validation completed at 375px, 768px, and 1440px with no horizontal overflow. pnpm test, TypeScript, Prettier, diff checks, and webpack compilation pass.

@dethan3

dethan3 commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

已按项目样式约定继续优化:删除 Footer.module.less(92 行),改由 Bootstrap 5.3 栅格和工具类承担布局、间距、分隔、对齐及响应式展示。已验证 375/768/1440px:无横向溢出;平板两列等分;桌面三列宽度均为 437.33px;开源图书馆仍保留 Catalog / How to Borrow 和原描述。pnpm test 与 CodeQL 均通过。Build-and-Deploy 仍因 Vercel Team fair-use 限额失败。提交:31786fa。

@TechQuery TechQuery left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有问题都要通篇改。

Comment thread components/Footer.tsx Outdated
Comment thread components/Footer.tsx Outdated
Comment thread components/Footer.tsx Outdated
Comment thread components/Footer.tsx Outdated

@TechQuery TechQuery left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有问题通篇要改

Comment thread translation/zh-CN.ts Outdated
Comment thread components/Footer.tsx Outdated
dethan3 and others added 2 commits August 28, 2026 18:30
Co-authored-by: South Drifter <shiy2008@gmail.com>
Co-authored-by: South Drifter <shiy2008@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

页脚文案容易让人将“开源市集”误解为图书馆项目

2 participants