Repository navigation
examples/camera_streamer: carry a qualified sensor capture time to LiveKit - #1479
Open
gareth-morgan-nv wants to merge 2 commits into
Open
gareth-morgan-nv wants to merge 2 commits into
gareth-morgan-nv wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
gareth-morgan-nv
requested review from
farbod-nv,
jsepulveda-nvidia,
nv-jakob and
tengw-nv
November 11, 2026 04:36
This was referenced Nov 11, 2026
…erve a clock responder The AVS1 bundle gains an optional timing extension (flag 0x0008): one 24-byte record per sample with the sensor capture instant on the sender's monotonic clock, the sender's stated uncertainty, the anchor age and a validity bit. The receiver parses and validates it and publishes the fields in the IPC metadata. The mock sender emits it from a synthetic sender monotonic clock with its own offset, drift and steps, writes the true capture instant on this host's clock to a ground-truth file, and serves the sender's stateless UDP clock responder (13-byte Q, 29-byte R) with mute, loss and reorder faults for tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
…ground truth Scenarios through the real receiver, bridge and a local LiveKit server with a sender clock offset and drift: accuracy, a clock step, a session restart, a stale clock mapping, lost and reordered replies, invalid timing records, and refusal without a sender clock. The mock's lint fix rides along. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
gareth-morgan-nv
force-pushed
the
gmorgan/CameraStreamingLiveKit
branch
from
November 11, 2026 05:40
83b23e2 to
d950e1f
Compare
gareth-morgan-nv
force-pushed
the
gmorgan/CameraStreamingTiming
branch
from
November 11, 2026 05:40
57c7ab4 to
eecc167
Compare
gareth-morgan-nv
had a problem deploying
to
dev
November 11, 2026 06:26 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Receiver, mock and bridge side of capture-time alignment. Stacked on the bridge PR.
0x0008: one 24-byte record per sample with the sensor capture instant on the sender's monotonic clock, its stated uncertainty, anchor age and a validity bit. The receiver parses and validates it and publishes the fields in the IPC metadata.capture_monotonic_usonly for frames that qualify: valid record, current mapping with warm-up, mapping plus sensor uncertainty within the budget, possible age. Otherwise no capture time is published and frame-ready time is never substituted. A reply counts only from the sender's address, of the exact size and tag, matching the outstanding request and the current session generation.Limitations
A step of the sender clock shows at the next exchange, so frames in between (at most one exchange interval) carry the old offset; a learned age level cannot tell a step from a stall, so none is used. The sender side (real Orin) is not part of this PR and has not been qualified against it.
Testing
ctest 7/7 (clock-estimator golden vectors from egocap's estimator, qualifier, UDP client against a fake sender, plus the existing targets). A scenario test through the real receiver, bridge and a local LiveKit server (accuracy, step, restart, stale mapping, loss and reorder, invalid records, refusal) passed twice; with a 1.2 s offset and 50 ppm drift the published capture time is within about 100 us of ground truth. A take saved by the unchanged egocap timing recorder matched ground truth within 0.84 ms. The scenario test was reformatted after those runs and not rerun.
🤖 Generated with Claude Code