Skip to content

Use the standard Trino JDBC provider and remove YDB merge sinks - #261

Merged
KirillKurdyukov merged 6 commits into
mainfrom
codex/trino-merge-one-attempt
Sep 11, 2026
Merged

Use the standard Trino JDBC provider and remove YDB merge sinks#261
KirillKurdyukov merged 6 commits into
mainfrom
codex/trino-merge-one-attempt

Conversation

@KirillKurdyukov

@KirillKurdyukov KirillKurdyukov commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Uses Trino 483's default JdbcPageSinkProvider and JdbcMergeSink for YDB writes. YdbConnector now receives ConnectorPageSinkProvider through the binding already supplied by JdbcModule; production and test modules no longer bind a custom provider.

Deletes YdbPageSinkProvider, YdbMergeSink, and YdbRetryUtils. The connector no longer owns MERGE buffering or transaction replay. Existing ordered primary-key metadata, one writer task, and rejection of query/task retries remain unchanged. The roadmap and client comment reflect the standard sink behavior.

INSERT, DELETE, and UPDATE can commit batches through separate connections. Whole-MERGE atomicity and rollback across all operation sinks are not provided. No capability changes, new PK guard, retry wrapper, or test exclusions are added.

The complete diff against main is 17 additions and 614 deletions (631 total) across 8 files. The user explicitly approved exceeding the usual 200-line limit for this removal and wiring change.

Validation for final revision 3c7d813d7df953e51ac4220dacba7c2063a633b7:

  • JDK 25 production and test compilation passed (13 production sources, 5 test sources); whitespace validation passed and no references to the deleted types remain.
  • Independent source review approved this exact SHA.
  • Full adapter CI on JDK 25 and JDBC 2.4.1 passed: 307 tests, 222 passed, 85 skipped, 0 failures, 0 errors. It includes the unchanged inherited MERGE/UPDATE and smoke groups. CI tested merge 163a2815376c50041811469eb92113e8c9f88290 with main 6943891bcc45232e14be33f51519f6b3ed0796c9.
  • Local Docker is unavailable; runtime validation comes from this full CI run. No new capability or inherited coverage gain is claimed. The suite does not establish arbitrary native-key support or rollback across operation sinks.

@KirillKurdyukov
KirillKurdyukov marked this pull request as ready for review September 11, 2026 11:45
@KirillKurdyukov

KirillKurdyukov commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Кирилл, окончательный PR готов — ревью 1/1 среди готовых, после уже merged JDBC #260.

Используются штатные JdbcPageSinkProvider и JdbcMergeSink Trino. YdbPageSinkProvider, YdbMergeSink и YdbRetryUtils удалены; production/test wiring подключены через стандартный интерфейс. Размер +17/−614=631 строка, 8 файлов — разрешённое тобой исключение из лимита для этой очистки. Head:3c7d813d7df953e51ac4220dacba7c2063a633b7.

Независимое ревью exactSHA и локальные JDK25 compile/test-compile прошли. Финальный полный CI: https://github.com/ydb-platform/ydb-java-dialects/actions/runs/34598335627 — 307 тестов,222 passed,85 skipped,0 failures,0 errors. Это результат версии с удалёнными классами. Локальный Docker недоступен; runtime подтверждён CI.

Операции могут коммититься отдельно; общей атомарности MERGE не заявляем. Оставшихся незамерженных зависимостей нет. Даты последуют отдельно. Автоматического merge не будет; комментарий обновлён без нового @-пинга.

@KirillKurdyukov
KirillKurdyukov marked this pull request as draft September 11, 2026 11:57
@KirillKurdyukov KirillKurdyukov changed the title Remove connector-owned YDB MERGE replay Use Trino JDBC merge sink for YDB Sep 11, 2026
@KirillKurdyukov
KirillKurdyukov marked this pull request as ready for review September 11, 2026 12:07
@KirillKurdyukov
KirillKurdyukov marked this pull request as draft September 11, 2026 12:17
@KirillKurdyukov KirillKurdyukov changed the title Use Trino JDBC merge sink for YDB Use the standard Trino JDBC provider and remove YDB merge sinks Sep 11, 2026
@KirillKurdyukov
KirillKurdyukov marked this pull request as ready for review September 11, 2026 12:24
@KirillKurdyukov
KirillKurdyukov merged commit 119d4bc into main Sep 11, 2026
1 check passed
@KirillKurdyukov
KirillKurdyukov deleted the codex/trino-merge-one-attempt branch September 11, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant