Support physical YDB Date and Date32 columns in Trino - #262
Draft
KirillKurdyukov wants to merge 10 commits into
Draft
Support physical YDB Date and Date32 columns in Trino#262KirillKurdyukov wants to merge 10 commits into
KirillKurdyukov wants to merge 10 commits into
Conversation
KirillKurdyukov
marked this pull request as ready for review
September 11, 2026 12:55
Collaborator
Author
|
По прямому замечанию пользователя PR возвращён в DRAFT: ручные границы Date/Date32 и собственный валидатор пересматриваются. Прежнее приглашение на ревью отменено; зелёный CI для |
KirillKurdyukov
marked this pull request as draft
September 11, 2026 13:03
This reverts commit a167d62.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT — the user-requested shared Date32 binding experiment failed. Not ready for review or merge.
Candidate
2e55656, 4 files, +158/−19 = 177 lines against main119d4bce, removes manual range constants and tries a shared Date32 writer with full predicate pushdown. JDK25 compilation passed, but CI34605014314 rejects this hypothesis:> DATE '-0001-01-01'and< DATE '2106-01-01'each returned0 rows instead of1. Both equality checks correctly returned empty. The exact range-comparison cause is still undetermined.Cannot cast parameter [legacy_key] from [Date32] to [Date], even for2020-01-01. This agrees with JDBC2.4.1 strict parameter type checking. Later NULL/UPDATE/MERGE/DDL checks were not reached.Final CI: default UTC309 total/221 passed/85 skipped/3 failures/0 errors; signed UTC309/222/85/2/0; focused Moscow2/0/0/2/0. Default additionally fails inherited negative INSERT on the strict type mismatch. Local Docker was unavailable; runtime evidence is CI. No inherited expectation was weakened to accept broken writes.
The separate predicate and write tests preserve these failures as diagnostic evidence. Earlier green CI for
909d96cis historical and does not validate the current candidate. Feature support is incomplete; no broader SQL/predicate redesign has been implemented.