Skip to content

Support physical YDB Date and Date32 columns in Trino - #262

Draft
KirillKurdyukov wants to merge 10 commits into
mainfrom
codex/trino-date-types
Draft

Support physical YDB Date and Date32 columns in Trino#262
KirillKurdyukov wants to merge 10 commits into
mainfrom
codex/trino-date-types

Conversation

@KirillKurdyukov

@KirillKurdyukov KirillKurdyukov commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

DRAFT — the user-requested shared Date32 binding experiment failed. Not ready for review or merge.

Candidate 2e55656, 4 files, +158/−19 = 177 lines against main 119d4bce, removes manual range constants and tries a shared Date32 writer with full predicate pushdown. JDK25 compilation passed, but CI34605014314 rejects this hypothesis:

  • Native seed readback and unfiltered Trino visibility passed in both catalogs. For stored Date2020-01-01, filters > DATE '-0001-01-01' and < DATE '2106-01-01' each returned0 rows instead of1. Both equality checks correctly returned empty. The exact range-comparison cause is still undetermined.
  • Independent physical INSERT failed in both catalogs: Cannot cast parameter [legacy_key] from [Date32] to [Date], even for2020-01-01. This agrees with JDBC2.4.1 strict parameter type checking. Later NULL/UPDATE/MERGE/DDL checks were not reached.

Final CI: default UTC309 total/221 passed/85 skipped/3 failures/0 errors; signed UTC309/222/85/2/0; focused Moscow2/0/0/2/0. Default additionally fails inherited negative INSERT on the strict type mismatch. Local Docker was unavailable; runtime evidence is CI. No inherited expectation was weakened to accept broken writes.

The separate predicate and write tests preserve these failures as diagnostic evidence. Earlier green CI for 909d96c is historical and does not validate the current candidate. Feature support is incomplete; no broader SQL/predicate redesign has been implemented.

@KirillKurdyukov
KirillKurdyukov marked this pull request as ready for review September 11, 2026 12:55
@KirillKurdyukov

KirillKurdyukov commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

По прямому замечанию пользователя PR возвращён в DRAFT: ручные границы Date/Date32 и собственный валидатор пересматриваются. Прежнее приглашение на ревью отменено; зелёный CI для 909d96c относится только к предыдущей реализации. Новая версия пройдёт проверку совместимости со стандартным MERGE, независимое ревью и все три CI-конфигурации. Нового приглашения на ревью пока нет.

@KirillKurdyukov
KirillKurdyukov marked this pull request as draft September 11, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant