feat: add initial OOD sampling to BitZ commitments - #76
Open
shreyas-londhe wants to merge 3 commits into
Open
shreyas-londhe wants to merge 3 commits into
shreyas-londhe wants to merge 3 commits into
Conversation
shreyas-londhe
marked this pull request as ready for review
September 23, 2026 06:53
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an initial out-of-domain (OOD) evaluation of the committed packed witness before the Spartan and BitZ challenges. Batch that claim into the existing Ligerito opening.
CommitSchemewith transcript-aware commitment and verification methods. Retain the same OOD claim for dense and succinct openings.CommittedWitnessfrom circuit commitment and consume it during proving, preserving the transcript that sampled the OOD point. Verification receives the claim before replaying circuit proof challenges.This changes the BitZ and circuit proof transcripts and the circuit commitment API. Raw
Pcs::commitremains available without OOD; callers using the OOD path must continue the commitment transcript through opening.Regression tests cover altered, missing, and truncated OOD values, invalid grinding nonces, and dense/succinct round trips. Focused PCS, BitZ, and circuit tests, Clippy, formatting, and Rustdoc checks passed locally; the all-shapes test reaching m28 was not completed. Byte-for-byte transcript equivalence with BitZ-PoC remains unverified.