Skip to content

Supporting parts and background-scroll (no static styling for resize) - #364

Merged
ameerf-wix merged 4 commits into
masterfrom
supporting-parts
Oct 26, 2026
Merged

ameerf-wix merged 4 commits into
masterfrom
supporting-parts

Conversation

@ameerf-wix

Copy link
Copy Markdown
Contributor

Description

  • adds parts support for DOM animations lookup
  • adds partial parts support for CSS generation (cascade of parts can only works with overriding the parts again or mutually exclusive conditions)
  • exports parts from presets
  • fixes custom wiring for bgscroll presets

No static styling yet as it requires further design.

Related Issue

Checklist

  • I have read the Contributing Guide
  • I have added/updated tests for my changes (if applicable)
  • I have updated documentation/rules/skills (if applicable)

Screenshots / Demos

Additional Notes

return style(options, true);
}

export const parts = ['BG_LAYER', 'BG_MEDIA'];

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const parts = ['BG_LAYER', 'BG_MEDIA'];
export const parts = ['MEDIA_CLIP', 'MEDIA_WRAPPER'];

@ameerf-wix
ameerf-wix merged commit 7cdce61 into master Oct 26, 2026
1 check passed
@ameerf-wix
ameerf-wix deleted the supporting-parts branch October 26, 2026 16:19
ameerf-wix added a commit that referenced this pull request Oct 26, 2026
getCSSAnimation() no longer returns `target` (replaced by `part` in #364),
so the fixture adapter crashed on `target.startsWith`.

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants