Repository navigation
fix(motion): fix CSS runtime e2e fixture after target removal - #370
Merged
Merged
Conversation
getCSSAnimation() no longer returns `target` (replaced by `part` in #364), so the fixture adapter crashed on `target.startsWith`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motion E2E has been failing since #364 (run):
getCSSAnimation()now returnspartin place oftarget, so the effects fixture'sgetCssTargetElement(firstAnimation.target)threwtarget is undefinedin both CSS Runtime Consumption tests on every browser.The fixture adapter now takes the element id it already passed to
getCSSAnimation()and builds the selector from that id plus the optionalpart.Test plan
yarn test:e2e e2e/tests/effects.spec.ts: 57/57 passing (chromium, firefox, webkit)🤖 Generated with Claude Code