Repository: Align expanded Code search controls - #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Code dropdown’s expanded search combined mismatched standalone input, dropdown, and button styles: the mode selector had extra rounding/padding and a different height, and the search button was misaligned.
Introduce an opt-in shared search-control style with one 32px outer frame, a flexible query field, compact mode selector, centered icons, and consistent focus states. Preserve Forgejo’s native Exact/Union/RegExp modes and submission. Anchor the mobile Code popover to the toolbar so the search field stays within the viewport.
Validation:
bun commitand all 351 tests pass. Chrome screenshots and measurements verified equal child heights, light/dark focus treatment, mobile viewport containment, mode selection, and a successful RegExp search. The separate collapsed-spacing fix is #38.