Clean up btrblocks compressor interface#7274
Merged
connortsui20 merged 1 commit intodevelopfrom Apr 2, 2026
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
gatesn
approved these changes
Apr 2, 2026
connortsui20
added a commit
that referenced
this pull request
Apr 3, 2026
## Summary Continuation of #7274 Cleans up the `WriteStrategyBuilder` interface to allow EITHER an opaque compressor OR a `BtrBlocksCompressorBuilder` that we can modify at any point before building the write strategy. ## API Changes `WriteStrategyBuilder` now allows you to add a compressor plugin that will only override a default `BtrBlocksCompressorBuilder`. This means that whenever we add specific encodings, we are still able to exclude things like `IntDictScheme` when building the data compressor (which we did not do before) ## Testing The APIs have changed but the logic hasn't really changed, so existing tests should suffice. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We had a very strange interface for the
BtrBlocksCompressorand builder previously. However, now that the compressor is fully pluggable, we can make it a lot nicer.API Changes
Reduces the API (and really the semantics) of the
BtrBlocksCompressorto just a default with a methods that allow us to add new (pluggable) schemes and exclude schemes by ID. And then for compact encodings there's just a simple helper function that wraps thosewith_compact.Testing
The interface changes, but none of the logic changed.