Open
Conversation
connortsui20
force-pushed
the
ct/pluggable-btr-writer
branch
from
423277e to
3adefa1
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/pluggable-btr-writer
branch
from
3adefa1 to
0ec1d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #7274
Cleans up the
WriteStrategyBuilderinterface to allow EITHER an opaque compressor OR aBtrBlocksCompressorBuilderthat we can modify at any point before building the write strategy.API Changes
WriteStrategyBuildernow allows you to add a compressor plugin that will only override a defaultBtrBlocksCompressorBuilder. This means that whenever we add specific encodings, we are still able to exclude things likeIntDictSchemewhen building the data compressor (which we did not do before)Testing
The APIs have changed but the logic hasn't really changed, so existing tests should suffice.