Skip to content

Add list_contains membership benchmarks - #10060

Open
robert3005 wants to merge 5 commits into
developfrom
rk/list-contains-benchmarks
Open

robert3005 wants to merge 5 commits into
developfrom
rk/list-contains-benchmarks

Conversation

@robert3005

@robert3005 robert3005 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add constant-set list_contains benchmarks before the prepared-set optimizations, so the same workloads can measure the existing comparison/OR implementation and the optimized implementation.

Stack order: #10057 (SQL null semantics) → this PR → #10052 (membership optimizations) → #10053 (Java/JNI and Python bindings) → #10054 (DuckDB integration).

Changes

  • Move vortex-array/benches/list_contains_set.rs and its Cargo benchmark registration out of Optimize list_contains with prepared constant sets #10052.
  • Cover dense and random integers, UTF-8, decimals, nested lists, large sets, and flat and chunked needles.
  • Preserve the benchmark source unchanged for before/after comparisons.

Validation: cargo clippy -p vortex-array --bench list_contains_set --all-features -- -D warnings passed on this branch. Runtime tests and benchmarks were not executed.

@codspeed

codspeed Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 14.33%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 2061 untouched benchmarks
🆕 4 new benchmarks
⏩ 503 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime compare_u64_avx512 3.7 µs 3.3 µs +14.33%
🆕 Simulation i64_random_chunked[256] N/A 20.8 ms N/A
🆕 Simulation i64_random[256] N/A 5.7 ms N/A
🆕 Simulation nested_list_random[32] N/A 7.4 ms N/A
🆕 Simulation utf8_random[256] N/A 14.4 ms N/A

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/list-contains-benchmarks (27f94c1) with develop (0852739)

Open in CodSpeed

Footnotes

  1. 503 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005
robert3005 force-pushed the rk/list-contains-benchmarks branch 4 times, most recently from 8d837fb to e71e6ad Compare September 25, 2026 17:26
@robert3005
robert3005 force-pushed the rk/list-contains-benchmarks branch from e71e6ad to cbc910b Compare September 25, 2026 20:28
@robert3005
robert3005 force-pushed the rk/list-contains-benchmarks branch from cbc910b to 5b1960d Compare September 28, 2026 20:43
@robert3005
robert3005 marked this pull request as ready for review September 28, 2026 20:43
@robert3005 robert3005 added the changelog/chore A trivial change label Sep 28, 2026
@joseph-isaacs

Copy link
Copy Markdown
Contributor

less than 26 benchmarks please can we have only 1 or 2?

@robert3005

robert3005 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor Author

I think we can get it down to 6 4

Base automatically changed from rk/list-contains-sql-null-semantics to develop September 29, 2026 19:12
@robert3005
robert3005 force-pushed the rk/list-contains-benchmarks branch from 9522a70 to 7cae7b2 Compare September 29, 2026 19:12
robert3005 and others added 4 commits September 29, 2026 12:13
Benchmark constant-set membership before introducing prepared-set probes.
Cover dense and random integers, UTF-8, decimals, nested lists, large sets,
and flat and chunked needles using the same workloads for comparisons.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Keep one benchmark per probe kind, integers, UTF-8 strings, and nested
lists, each at a small and a large set, plus integer needles split into
chunks, so that every benchmark stays under 1ms of CodSpeed simulation
once constant sets are prepared as probes. Nested sets compare whole
rows and stay smaller.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 force-pushed the rk/list-contains-benchmarks branch from 7cae7b2 to 89feff4 Compare September 29, 2026 19:13
Keep one set size per benchmark, four cases in all, so CodSpeed runs
the sizes that show the probe cost rather than the setup cost.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants