Skip to content

Add SQL null semantics to list_contains - #10057

Merged
robert3005 merged 6 commits into
developfrom
rk/list-contains-sql-null-semantics
Sep 29, 2026
Merged

robert3005 merged 6 commits into
developfrom
rk/list-contains-sql-null-semantics

Conversation

@robert3005

@robert3005 robert3005 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Add explicit SQL three-valued membership semantics to list_contains. A nonmatch against a list containing null yields null, so NOT IN does not admit that row. Regular semantics that flush null to false are still present

@codspeed

codspeed Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 5.18%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 2059 untouched benchmarks
⏩ 503 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation sum_i64 193.3 µs 224.6 µs -13.94%
❌ Simulation sum_v2_i64 193.8 µs 225 µs -13.85%
⚡ WallTime dict_canonicalize_gt_u8_neon[1000000] 561.6 µs 488.4 µs +14.98%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/list-contains-sql-null-semantics (de591fc) with develop (52e6407)

Open in CodSpeed

Footnotes

  1. 503 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005 robert3005 added the changelog/feature A new feature label Sep 25, 2026
@robert3005
robert3005 marked this pull request as ready for review September 25, 2026 17:23
@robert3005
robert3005 force-pushed the rk/list-contains-sql-null-semantics branch 2 times, most recently from 70a4ae8 to 339690d Compare September 25, 2026 20:28
Comment thread encodings/sequence/src/compute/list_contains.rs Outdated
Comment thread encodings/sequence/src/compute/list_contains.rs Outdated
Comment thread vortex-datafusion/src/convert/exprs.rs Outdated
Comment thread vortex-array/src/scalar_fn/fns/list_contains/mod.rs Outdated
@robert3005
robert3005 force-pushed the rk/list-contains-sql-null-semantics branch from cfc73a6 to b63d5e9 Compare September 28, 2026 20:33
robert3005 and others added 6 commits September 28, 2026 16:39
Add explicit SQL three-valued membership semantics, including nullable
return types, expression helpers, option serialization, and propagation
through sequence kernels. Use SQL semantics for DataFusion IN conversion.

Retain the existing comparison/OR evaluation for constant sets. Set
preparation and single-pass probes follow in the next change.

Include null-semantics regressions for scalar and column inputs, empty
and null lists, sequence fallback, serialization, and DataFusion.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Remove the unsupported trailing macro comma and clone the schema Arc
explicitly to satisfy the repository lint configuration.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Enable the vortex-array test harness explicitly for DataFusion tests so standalone test compilation does not depend on features enabled by other workspace packages.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 force-pushed the rk/list-contains-sql-null-semantics branch from b63d5e9 to de591fc Compare September 28, 2026 20:43
@robert3005
robert3005 merged commit 3d4aea8 into develop Sep 29, 2026
91 of 93 checks passed
@robert3005
robert3005 deleted the rk/list-contains-sql-null-semantics branch September 29, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants