fix(codecs): preserve logical types in generated Avro schema fixtures - #26000
Open
omwbennett wants to merge 1 commit into
Open
fix(codecs): preserve logical types in generated Avro schema fixtures#26000omwbennett wants to merge 1 commit into
omwbennett wants to merge 1 commit into
Conversation
8 tasks
pront
approved these changes
Aug 3, 2026
pront
enabled auto-merge
August 3, 2026 18:24
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current Avro schema fixtures drop any schema metadata such as
logicalTypewhich makes it impossible to test the encoding/decoding of fields containing logical types e.g.To fix, serialize the schema with
serde_jsoninstead ofcanonical_form()to preserve the logical type annotations.Vector configuration
N/A
How did you test this PR?
Re-ran
cargo run --package codecs --bin generate-avro-fixturesandcargo test -p codecs avropasses.Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.