feat(mapper): add entity-proto mappers and streaming splitters#211
Open
yushan8 wants to merge 1 commit into
Open
feat(mapper): add entity-proto mappers and streaming splitters#211yushan8 wants to merge 1 commit into
yushan8 wants to merge 1 commit into
Conversation
3 tasks
yushan8
marked this pull request as draft
July 17, 2026 04:11
3 tasks
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 17, 2026 05:13
9bd4bdf to
d05117c
Compare
yushan8
force-pushed
the
yushan/entity-target-graph
branch
from
July 17, 2026 05:13
4cb3028 to
fba8c52
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
3 times, most recently
from
July 17, 2026 22:57
ecb2996 to
36f3f33
Compare
yushan8
force-pushed
the
yushan/entity-target-graph
branch
from
July 17, 2026 22:57
fba8c52 to
34e6a59
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
4 times, most recently
from
July 20, 2026 02:03
b621c93 to
03833f5
Compare
yushan8
force-pushed
the
yushan/entity-target-graph
branch
2 times, most recently
from
July 20, 2026 03:20
ac6aea4 to
facc62d
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
2 times, most recently
from
July 20, 2026 03:28
8ba38ac to
6fc3266
Compare
yushan8
force-pushed
the
yushan/entity-target-graph
branch
from
July 20, 2026 03:28
facc62d to
ef4db65
Compare
1 task
3 tasks
yushan8
force-pushed
the
yushan/entity-target-graph
branch
from
July 20, 2026 03:42
ef4db65 to
1b416d5
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
2 times, most recently
from
July 20, 2026 03:46
0f5a89c to
5fb83ae
Compare
yushan8
force-pushed
the
yushan/entity-target-graph
branch
from
July 20, 2026 03:46
1b416d5 to
ac18fbe
Compare
yushan8
marked this pull request as ready for review
July 20, 2026 04:43
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 20, 2026 04:52
5fb83ae to
7f55e85
Compare
yushan8
force-pushed
the
yushan/entity-target-graph
branch
from
July 20, 2026 04:52
ac18fbe to
9789ce1
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 20, 2026 05:27
7f55e85 to
e762db8
Compare
yushan8
force-pushed
the
yushan/entity-target-graph
branch
from
July 20, 2026 05:27
9789ce1 to
061115e
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 20, 2026 16:52
e762db8 to
dff47a4
Compare
yushan8
force-pushed
the
yushan/entity-target-graph
branch
from
July 20, 2026 17:16
6b968d3 to
2da7020
Compare
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 20, 2026 17:17
dff47a4 to
9c060bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/streaming/withSplitBySize(generic wire-size splitter) andSplitMetadata(splits metadata maps across chunks). Proto-free package.ResultToTargetGraph: convertstargethasher.Resultto([]entity.OptimizedTarget, *entity.Metadata)ChunkTargetGraph: splits targets + metadata into[]entity.GetTargetGraphResponsewithin a byte budgetGetTargetGraphResponseToProto: entity → proto converter for the gRPC boundaryChangedTargetsResponseToProto: entity → proto converter for the changed-targets gRPC boundaryTest plan
make build && make test— 19/19 passinternal/streaming/streaming_test.go— SplitBySize, SplitMetadata, wire size equivalenceinternal/mapper/target_graph_test.go— ResultToTargetGraph, ChunkTargetGraph, GetTargetGraphResponseToProto round-tripmake gazelleStack