Skip to content

feat(entity): add entity types for target graph and changed targets#210

Merged
yushan8 merged 2 commits into
mainfrom
yushan/entity-target-graph
Jul 20, 2026
Merged

feat(entity): add entity types for target graph and changed targets#210
yushan8 merged 2 commits into
mainfrom
yushan/entity-target-graph

Conversation

@yushan8

@yushan8 yushan8 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add entity.OptimizedTarget, entity.Metadata, and entity.GetTargetGraphResponse as compact, proto-free representations of the target graph wire types
  • Add entity.ChangedTarget and entity.GetChangedTargetsResponse for the changed-targets path
  • These entity types mirror the proto definitions but live in a dependency-free package, preventing proto from leaking into storage, orchestrator, and other non-transport layers

Test plan

  • make build && make test && make gazelle

Stack

  1. feat(entity): add entity types for target graph and changed targets #210 — this PR (entity types)
  2. feat(mapper): add entity-proto mappers #211 (mappers + streaming)
  3. refactor: replace proto serialization with JSON and migrate callsites #222 (storage JSON rewrite)
  4. refactor: migrate callsites to entity types and consolidate config #212 (callsite migration + cleanup)

@yushan8
yushan8 requested review from a team as code owners July 16, 2026 23:23
@yushan8
yushan8 marked this pull request as draft July 17, 2026 04:11
@yushan8
yushan8 force-pushed the yushan/entity-target-graph branch 5 times, most recently from facc62d to ef4db65 Compare July 20, 2026 03:28
@yushan8
yushan8 marked this pull request as ready for review July 20, 2026 03:35
@yushan8 yushan8 changed the title feat(entity): add compact ID-mapped target graph types feat(entity): add entity types for target graph and changed targets Jul 20, 2026
@yushan8
yushan8 force-pushed the yushan/entity-target-graph branch 4 times, most recently from 9789ce1 to 061115e Compare July 20, 2026 05:27
yushan8 and others added 2 commits July 20, 2026 10:15
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Add entity.ChangeType as a typed enum with Invalid/New/Deleted/Changed
values matching the proto definition. Update ChangedTarget.ChangeType
from int32 to the new type.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yushan8
yushan8 force-pushed the yushan/entity-target-graph branch from 6b968d3 to 2da7020 Compare July 20, 2026 17:16
@yushan8
yushan8 merged commit 01373f0 into main Jul 20, 2026
10 checks passed
@yushan8
yushan8 deleted the yushan/entity-target-graph branch July 20, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants