Skip to content

[comp] Production Deploy #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tofikwest merged 3 commits into from
Jun 22, 2026
+13 −8
Merged

[comp] Production Deploy #3236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b57c63
chore: merge release v3.87.2 back to main [skip ci]
github-actions[bot] Jun 22, 2026
6cbd40f
fix(background-checks): drop HEIC/HEIF from manual upload accept list
tofikwest Jun 22, 2026
74a31fd
Merge pull request #3235 from trycompai/fix/bg-attach-drop-heic
tofikwest Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...p/src/app/(app)/[orgId]/people/[employeeId]/components/BackgroundCheckAttachForm.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ describe('BackgroundCheckAttachForm', () => {
expect(accept).toContain('application/pdf');
expect(accept).toMatch(/image\/png/);
expect(accept).toMatch(/image\/jpeg/);
expect(accept).toMatch(/image\/heic/);
expect(accept).toMatch(/image\/webp/);
// HEIC/HEIF intentionally excluded — the API can't validate/store them and
// most browsers can't display them; offering them would fail server-side.
expect(accept).not.toMatch(/image\/heic/);
});

it('still accepts a PDF report', () => {
Expand Down
16 changes: 9 additions & 7 deletions apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/BackgroundCheckAttachForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,21 @@ interface AttachFormProps {
const MAX_FILE_BYTES = 25 * 1024 * 1024;

// Reports are usually PDFs, but the manual identity fallback is a passport
// photo (JPEG/PNG/HEIC). The API accepts these same types — see
// validateFileContent in apps/api/src/utils/file-type-validation.ts.
// photo (JPEG/PNG/WEBP). Keep this in lock-step with what the API actually
// accepts — validateFileContent in apps/api/src/utils/file-type-validation.ts.
// HEIC/HEIF are intentionally excluded: the API can't validate/store them and
// most browsers can't display them, so they'd fail server-side or store
// unviewable evidence. (Candidates' own uploads convert HEIC->JPEG in the
// browser via apps/web normalizeIdImage; this admin attach form does not.)
const ACCEPTED_MIME_TYPES = [
'application/pdf',
'image/png',
'image/jpeg',
'image/webp',
'image/heic',
'image/heif',
];

const FILE_ACCEPT_ATTR =
'application/pdf,image/png,image/jpeg,image/webp,image/heic,image/heif,.pdf,.png,.jpg,.jpeg,.webp,.heic,.heif';
'application/pdf,image/png,image/jpeg,image/webp,.pdf,.png,.jpg,.jpeg,.webp';

export function BackgroundCheckAttachForm({
values,
Expand All @@ -81,7 +83,7 @@ export function BackgroundCheckAttachForm({
return;
}
if (file.type && !ACCEPTED_MIME_TYPES.includes(file.type)) {
setFileError('Upload a PDF or image file (PDF, PNG, JPG, HEIC).');
setFileError('Upload a PDF or image file (PDF, PNG, JPG, WEBP).');
return;
}
setFileError(null);
Expand Down Expand Up @@ -178,7 +180,7 @@ export function BackgroundCheckAttachForm({
)}
</Text>
<Text size="xs" variant="muted">
PDF or image (PNG, JPG, HEIC) · up to 25 MB · stored encrypted in your evidence vault
PDF or image (PNG, JPG, WEBP) · up to 25 MB · stored encrypted in your evidence vault
</Text>
{fileError && (
<p className="mt-2 text-xs text-destructive">{fileError}</p>
Expand Down
Loading