Conversation
PR #3233 widened the background-check attach form to accept images, but included image/heic + image/heif. The API (validateFileContent in apps/api/src/utils/file-type-validation.ts) only validates PNG/JPEG/WEBP/PDF, so a HEIC/HEIF upload would be rejected server-side — and most browsers can't display HEIC, so it would store unviewable evidence even if accepted. Align the form's accepted types (and helper/error copy) with what the API actually takes: PDF, PNG, JPEG, WEBP. PDFs and the other image formats are unaffected. Note: candidates' own ID uploads already handle HEIC by converting it to JPEG in the browser (apps/web normalizeIdImage). This admin attach form does no such conversion, so offering HEIC here was misleading. If HEIC support is wanted on this form later, the right fix is client-side conversion, not raw HEIC at the API. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fix(background-checks): drop HEIC/HEIF from manual upload accept list
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.87.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Aligns the background-check attachment form with API-supported types by removing HEIC/HEIF and allowing WEBP to prevent failed uploads and ensure viewable evidence.
BackgroundCheckAttachFormand the inputacceptattribute.Written for commit 74a31fd. Summary will update on new commits.