Skip to content

Add MIT license and require iOS 15 / macOS 12 - #50

Merged
kvz merged 3 commits into
mainfrom
license-min-os
Oct 8, 2026
Merged

kvz merged 3 commits into
mainfrom
license-min-os

Conversation

@kvz

@kvz kvz commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

The 3.6.0 publication needed a validation override for obsolete deployment targets and allowed warnings for a missing license. Ship the declared MIT license and propose iOS 15.0 / macOS 12.0 consistently in CocoaPods and Swift Package Manager. Xcode 27.0 reports these as its lowest supported deployment targets, they match the 3.6.0 validation build, and the SDK code needs nothing higher. Kevin decides the minimums at merge time.

This raises the requirements for the next release. Apps supporting older OS versions must stay on 3.6.0 or earlier; existing releases retain their original metadata.

The MIT text and Copyright (c) 2014 Tim Koschuetzki notice match node-sdk's license. Preserve this SDK's earlier MIT notices from commits 1f4a3b6 (2016, Mark R. Masterson) and 12026b7 (2019, mmasterson), which disappeared during the 2021 rewrite. Replace the unused session configuration binding with the equivalent nil check; existing default/background session tests cover the behavior. Record the changes under Next and document the accepted TUSKit warning exception in CONTRIBUTING.md.

Align the example app's Debug and Release targets with iOS 15.0 so it can import the local package. Explain the accepted dependency limitation in both the contributor quickstart and the release instructions.

Closes #49.

Validation on studio1 (Xcode 27.0, Swift 6.4, CocoaPods 1.17.0):

  • Before: plain pod lib lint Transloadit.podspec failed with one build error plus the missing-license warning; Xcode rejected the SDK's iOS 10.0 / macOS 10.11 targets.
  • After: swift build passed; swift test passed all 30 tests, including all 12 session configuration tests. Tests retain existing deprecation/unused-value warnings.
  • Parsed SwiftPM and CocoaPods metadata both declare iOS 15.0 / macOS 12.0.
  • The example app's generic iOS Simulator build failed at iOS 14.0 before aligning the targets and passed at iOS 15.0, compiling both arm64 and x86_64. Command: xcodebuild -project TransloaditKitExample/TransloaditKitExample.xcodeproj -scheme TransloaditKitExample -configuration Debug -sdk iphonesimulator -destination 'generic/platform=iOS Simulator' CODE_SIGNING_ALLOWED=NO build. Xcode emitted only its AppIntents metadata-extraction warning.
  • CI on the final commit passed build and tests. Latest main is included.
  • Two council-review rounds: addressed the example target and contributor quickstart findings; the second round found no issues.
  • After: plain pod lib lint Transloadit.podspec still fails, solely on the TUSKit dependency's obsolete deployment targets. The license warning is gone. No XCODE_XCCONFIG_FILE override or --allow-warnings was used.
  • Follow-up: pod lib lint Transloadit.podspec --allow-warnings, with no XCODE_XCCONFIG_FILE override, also exits with one build error on Xcode 27 because it rejects TUSKit's targets outright. Kevin accepted this known dependency limitation for merging this PR.

Accepted dependency limitation: pod lib lint uses --allow-warnings only to accept deployment-target warnings from TUSKit 3.6.0's published podspec (iOS 10.0 / macOS 10.11), until TUSKit publishes newer minimums or TransloaditKit leaves CocoaPods. Xcode 27 rejects those targets with build errors, so the flag alone does not make lint pass on that toolchain:

[iOS] error: IPHONEOS_DEPLOYMENT_TARGET is set to 10.0; supported range is 15.0 to 27.0.x (target TUSKit)
[OSX] error: MACOSX_DEPLOYMENT_TARGET is set to 10.11; supported range is 12.0 to 27.0.x (target TUSKit)

TUSKit 3.6.0 is the latest CocoaPods release, and 3.7.0 removed CocoaPods support. Kevin chose to accept this dependency limitation and merge #50 as is. CONTRIBUTING.md limits the warning exception to TUSKit; publication still requires successful validation with a compatible toolchain or dependency fix and Kevin's approval after merge.

No release, version bump, tag, or CocoaPods trunk publication was performed.

🤖 Claimed by kvz/studio1/TransloaditKit since 2026-10-08

@kvz
kvz marked this pull request as ready for review October 8, 2026 06:20
@kvz
kvz requested a review from tim-kos October 8, 2026 06:20
@kvz
kvz merged commit 0cddb47 into main Oct 8, 2026
1 check passed
@kvz
kvz deleted the license-min-os branch October 8, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the LICENSE file and raise the minimum iOS/macOS versions

1 participant