Repository navigation
Add MIT license and require iOS 15 / macOS 12 - #50
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3.6.0 publication needed a validation override for obsolete deployment targets and allowed warnings for a missing license. Ship the declared MIT license and propose iOS 15.0 / macOS 12.0 consistently in CocoaPods and Swift Package Manager. Xcode 27.0 reports these as its lowest supported deployment targets, they match the 3.6.0 validation build, and the SDK code needs nothing higher. Kevin decides the minimums at merge time.
This raises the requirements for the next release. Apps supporting older OS versions must stay on 3.6.0 or earlier; existing releases retain their original metadata.
The MIT text and
Copyright (c) 2014 Tim Koschuetzkinotice match node-sdk's license. Preserve this SDK's earlier MIT notices from commits1f4a3b6(2016, Mark R. Masterson) and12026b7(2019, mmasterson), which disappeared during the 2021 rewrite. Replace the unused session configuration binding with the equivalent nil check; existing default/background session tests cover the behavior. Record the changes underNextand document the accepted TUSKit warning exception in CONTRIBUTING.md.Align the example app's Debug and Release targets with iOS 15.0 so it can import the local package. Explain the accepted dependency limitation in both the contributor quickstart and the release instructions.
Closes #49.
Validation on studio1 (Xcode 27.0, Swift 6.4, CocoaPods 1.17.0):
pod lib lint Transloadit.podspecfailed with one build error plus the missing-license warning; Xcode rejected the SDK's iOS 10.0 / macOS 10.11 targets.swift buildpassed;swift testpassed all 30 tests, including all 12 session configuration tests. Tests retain existing deprecation/unused-value warnings.xcodebuild -project TransloaditKitExample/TransloaditKitExample.xcodeproj -scheme TransloaditKitExample -configuration Debug -sdk iphonesimulator -destination 'generic/platform=iOS Simulator' CODE_SIGNING_ALLOWED=NO build. Xcode emitted only its AppIntents metadata-extraction warning.pod lib lint Transloadit.podspecstill fails, solely on the TUSKit dependency's obsolete deployment targets. The license warning is gone. NoXCODE_XCCONFIG_FILEoverride or--allow-warningswas used.pod lib lint Transloadit.podspec --allow-warnings, with noXCODE_XCCONFIG_FILEoverride, also exits with one build error on Xcode 27 because it rejects TUSKit's targets outright. Kevin accepted this known dependency limitation for merging this PR.Accepted dependency limitation:
pod lib lintuses--allow-warningsonly to accept deployment-target warnings from TUSKit 3.6.0's published podspec (iOS 10.0 / macOS 10.11), until TUSKit publishes newer minimums or TransloaditKit leaves CocoaPods. Xcode 27 rejects those targets with build errors, so the flag alone does not make lint pass on that toolchain:TUSKit 3.6.0 is the latest CocoaPods release, and 3.7.0 removed CocoaPods support. Kevin chose to accept this dependency limitation and merge #50 as is. CONTRIBUTING.md limits the warning exception to TUSKit; publication still requires successful validation with a compatible toolchain or dependency fix and Kevin's approval after merge.
No release, version bump, tag, or CocoaPods trunk publication was performed.
🤖 Claimed by kvz/studio1/TransloaditKit since 2026-10-08