Grant tigera-network-admin write access to UISettings in CRD mode#4834
Merged
caseydavenport merged 1 commit intoMay 20, 2026
Merged
Conversation
In v3 CRD / webhooks mode the calico-uisettings-passthrough ClusterRole is not deployed, so kube-apiserver RBAC denied UISettings writes before the calico-webhooks UISettings handler could narrow access via a SAR on uisettingsgroups/data. Add a uisettings write rule to tigera-network-admin that only applies when RequiresAggregationServer is false.
rene-dekker
approved these changes
May 20, 2026
caseydavenport
added a commit
that referenced
this pull request
May 20, 2026
) (#4839) In v3 CRD / webhooks mode the calico-uisettings-passthrough ClusterRole is not deployed, so kube-apiserver RBAC denied UISettings writes before the calico-webhooks UISettings handler could narrow access via a SAR on uisettingsgroups/data. Add a uisettings write rule to tigera-network-admin that only applies when RequiresAggregationServer is false. (cherry picked from commit c6c41bb)
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v3 CRD / webhooks mode (no aggregated calico-apiserver), a user bound to
tigera-network-admincan't create/update/delete UISettings. Thecalico-uisettings-passthroughClusterRole that grants the broad permission only ships whenRequiresAggregationServeris true, so kube-apiserver RBAC was denying the request before the calico-webhooks UISettings handler could narrow access via a SAR onuisettingsgroups/data.This adds a
uisettingswrite rule totigera-network-adminthat only applies whenRequiresAggregationServeris false. In aggregated mode the existing passthrough role still does the job and the apiserver's custom authorizer handles narrowing.Fixes CORE-12757.