Drop resourceNames from tigera-network-admin uisettings rule#4866
Merged
caseydavenport merged 2 commits intoMay 28, 2026
Conversation
UISettings names have the form <group>.<kind>.<name> (e.g. cluster-settings.layer.foo), and RBAC resourceNames is exact match, so the rule never matched a real layer-creation request. Drop the resourceNames so the webhook handles the group-level narrowing, which is how the comment said the rule was meant to work in the first place.
rene-dekker
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4834. The new rule granted write verbs on
uisettingsbut scoped them withresourceNames: ["cluster-settings", "user-settings"]. UISettings names actually have the form<group>.<kind>.<name>(e.g.cluster-settings.layer.tigera-infrastructure), and RBACresourceNamesis exact match, so the rule never matched a real create request - users bound totigera-network-adminin v3 CRD mode hit a 403 when the UI tried to create a Service Graph layer.Drop the
resourceNamesso the group-level narrowing happens in the calico-webhooks UISettings handler, which is how the rule's comment said it was meant to work.