Skip to content

feat(jazzy): add ament_index_cpp as dependency#36

Open
KYabuuchi wants to merge 1 commit intofeat/use_libgpiodfrom
feat/use_libgpiod_jazzy_migration
Open

feat(jazzy): add ament_index_cpp as dependency#36
KYabuuchi wants to merge 1 commit intofeat/use_libgpiodfrom
feat/use_libgpiod_jazzy_migration

Conversation

@KYabuuchi
Copy link

@KYabuuchi KYabuuchi commented Mar 17, 2026

PR Type

  • New Feature

Related Links

Description

Add ament_index_cpp as an explicit build/run dependency in package.xml.

This is required for ROS 2 Jazzy compatibility.
sensor_trigger.cpp uses ament_index_cpp::get_package_share_directory(). Without declaring this dependency, the build fails with:

/ros_ws/src/sensor_trigger/src/sensor_trigger.cpp:17:10: fatal error: ament_index_cpp/get_package_share_directory.hpp: No such file or directory
   17 | #include <ament_index_cpp/get_package_share_directory.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Review Procedure

Humble test ☑️

mkdir ros_ws/src -p
cd ros_ws/src
git clone git@github.com:tier4/sensor_trigger.git -b feat/use_libgpiod_jazzy_migration
cd ..
docker run -it --rm -v(pwd):/ros_ws -w /ros_ws ros:humble
sudo apt update
rosdep update
rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release

Jazzy test ☑️

mkdir ros_ws/src -p
cd ros_ws/src
git clone git@github.com:tier4/sensor_trigger.git -b feat/use_libgpiod_jazzy_migration
cd ..
docker run -it --rm -v(pwd):/ros_ws -w /ros_ws ros:jazzy
sudo apt update
rosdep update
rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi self-assigned this Mar 17, 2026
@KYabuuchi KYabuuchi requested review from drwnz and manato March 17, 2026 05:26
@KYabuuchi KYabuuchi marked this pull request as ready for review March 17, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant