Conversation
thomhurst
added
automated
dependencies
|
Too many files changed for review (1767 files, 100 file limit). |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Review: [Automated] Update gcloud CLI Options (#4877)This is a fully automated What I checked
Notes (non-blocking)
No actionable code issues found in the generated output itself. |
GitHub Actions
Failure
|
The original .NET validation run 34787372488 was canceled by workflow concurrency after I accidentally dispatched duplicate run 34787424555. I canceled the duplicate, confirmed both runs were terminal and no replacement was live, and reran the original once. The downstream failures only report that fast-fail was canceled; no test failure is being bypassed. This restores validation of head 956d976. |
|
Blocking finding from the final generated-output audit: GcloudMetastoreServicesMigrationsStartOptions.Generated.cs still prefixes Async, ConflictPolicy, DryRun, MigrationExecutionId, Mode, and ReportPath with both "Configuration for migrating Hive tables..." and "Configuration for migrating Iceberg tables...". HiveCatalog and IcebergCatalog also both receive both sibling introductions. This is the exact cross-group documentation defect that parent #4870 is meant to fix. Freshness matches the parent source and .NET run 34787372488 passes, including all seven Google integration tests, so this is a parser/fixture coverage gap rather than stale provenance or a build failure. The current CLEAR review did not detect it. This child must stay unmerged until the parser handles authoritative help formatting and the output is regenerated; no generated file will be patched by hand. |
|
Additional validation: yarn install --frozen-lockfile and yarn build pass with Node 24.14.1; git diff --check passes. This does not resolve the generated documentation blocker above. The authoritative SDK 584.0.0 help reproduces the defect: plain group headings and their flags share indentation, which the existing synthetic fixtures did not cover. Source correction is underway in parent #4870. |
956d976 to
d784a9a
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d784a9a220
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [GeneratedCode("ModularPipelines.OptionsGenerator", "2.0.0")] | ||
| [ExcludeFromCodeCoverage] | ||
| [CliSubCommand("metastore", "services", "migrations", "start")] | ||
| public record GcloudMetastoreServicesMigrationsStartOptions : GcloudOptions |
There was a problem hiding this comment.
The authoritative SDK 584 help fixture shows the synopsis (SERVICE : --location=LOCATION) and explicitly says this resource group must be specified (tools/ModularPipelines.OptionsGenerator/src/ModularPipelines.OptionsGenerator.Tests/Fixtures/Gcloud/metastore-services-migrations-start.txt, lines 5-13 and 47-79), but this new record exposes neither a Service operand nor a Location option. Consequently, StartAsync cannot construct a valid migration-start invocation using this options type; fix the scraper to retain the indented resource arguments and regenerate the output.
AGENTS.md reference: AGENTS.md:L33-L33
Useful? React with 👍 / 👎.
ReviewThis is a fully automated What I checked
Limitations of this review
No actionable issues found in the generated output itself. |
|
Verified the corrected output at d784a9a: the six top-level migration flags have their own descriptions, while Hive and Iceberg members each receive only their corresponding group introduction. The prior cross-group documentation blocker is fixed, matching the current-head CLEAR review. Two merge requirements remain. The branch has no automatically triggered .NET checks, so I dispatched full current-head validation: https://github.com/thomhurst/ModularPipelines/actions/runs/34795137379. Separately, comparing the current baselines with parent 7e58658 finds 155 newly added removal markers whose declarations are absent from the current shipped baseline (for example, the former GcloudAcceleratorType.NvidiaTeslaP100Vws = 7 entry). This is the baseline lifecycle defect addressed by #4644. The generation base needs that fix and a fresh authoritative regeneration before this PR can merge. No generated files or baselines were hand-edited. |
GitHub Actions
Failure
b3c750f to
0f63058
Compare
1 participant
Summary
This PR contains automatically generated updates to gcloud CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Assembly/common,Gcloud.Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP100Vws = 7 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP4Vws = 8 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4 = 5 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4Vws = 6 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaV100 = 3 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeRepresentative added members:
ModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP100Vws = 3 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP4Vws = 5 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4 = 6 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4Vws = 7 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaV100 = 8 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeCommand coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator