Conversation
(cherry picked from commit 3996816)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Too many files changed for review (2075 files, 100 file limit). |
Review: [Automated] Update gcloud CLI Options (#4876)This is an automated regeneration of the gcloud options classes (2075 files) triggered by scraper/generator changes on this branch. Per repo policy, the generated output itself is authoritative and not something to hand-edit, so I focused the review on the hand-written generator/scraper changes in The hand-written changes look solid
Bug: sibling argument groups collapse into one, corrupting generated XML docs (BLOCKING)
Since This is directly visible in a file shipped by this PR, Suggested direction: don't rely solely on keyword matching to decide whether a prelude starts a new group. The indentation-based branch ( Minor
Not flagging
|
|
The dispatched .NET validation completed successfully at https://github.com/thomhurst/ModularPipelines/actions/runs/34787391211, but this PR is not mergeable yet. The current-head Claude review found sibling-group documentation leaking across options; that concern remains applicable to this generator/output. The shared parser correction is tracked by #4870 (issue #4799), with authoritative output in #4877. This gcloud list-output PR must incorporate that correction and regenerate before the blocking review can be resolved. No generated documentation will be hand-patched, and green CI does not dispose of the review finding. |
eff9a98 to
afd988d
Compare
Summary
This PR contains automatically generated updates to gcloud CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Assembly/common,Gcloud.Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP100Vws = 7 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP4Vws = 8 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4 = 5 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4Vws = 6 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaV100 = 3 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeRepresentative added members:
ModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP100Vws = 3 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP4Vws = 5 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4 = 6 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4Vws = 7 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaV100 = 8 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeCommand coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator