Skip to content

Build with disable_grpc_modules to drop unused gRPC storage client #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephanos wants to merge 2 commits into from
Closed

Build with disable_grpc_modules to drop unused gRPC storage client #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db5a2f2
Build with disable_grpc_modules to drop unused gRPC storage client
stephanos Oct 12, 2026
5d22da0
Use the temporal server's comment for disable_grpc_modules
stephanos Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ builds:
- arm64
env:
- CGO_ENABLED=0
tags:
# The `disable_grpc_modules` build tag excludes gRPC dependencies from cloud.google.com/go/storage,
# reducing binary size since we only use the REST client (storage.NewClient), not the
# gRPC client (storage.NewGRPCClient). Related issue: https://github.com/googleapis/google-cloud-go/issues/12343
- disable_grpc_modules
id: nix
goos:
- linux
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ gen-docs: internal/temporalcli/commands.yaml cliext/option-sets.yaml
-output dist/docs

build:
go build ./cmd/temporal
go build -tags disable_grpc_modules ./cmd/temporal

test:
(cd cliext && go test ./...)
Expand Down
Loading