Repository navigation
Conversation
The dev server links cloud.google.com/go/storage through the Temporal server's GCS archiver. Without the disable_grpc_modules build tag, that package also links its gRPC client and the xDS/Envoy stack, which nothing uses. The Temporal server already builds its releases with this tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing: the upcoming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
What changed?
The release binaries (
.goreleaser.yml) andmake buildnow use thedisable_grpc_modulesbuild tag.The dev server links
cloud.google.com/go/storagethrough the Temporal server's GCS archiver. Without the tag, that package also links its gRPC client (storage.NewGRPCClient), which pulls in gRPC's xDS support and Envoy'sgo-control-plane. Nothing in the CLI uses the gRPC client, and the Temporal server already builds its releases with this tag (temporalio/temporal#12248). The comment in.goreleaser.ymlis the same as the server's. Related upstream issue: googleapis/google-cloud-go#12343.Stripped release binaries (
-ldflags "-s -w"):go install github.com/temporalio/cli/cmd/temporal@latestdoesn't pass build tags, so binaries built that way keep the gRPC client.Checklist
Tests
SharedServerSuite)func TestXxx) where applicableNo behavior change; existing tests cover the dev server.
Manual tests
Setup
Happy path
goreleaser checkvalidates the config, and the tagged binary contains noenvoyproxyorgoogledirectpathsymbols.🤖 Generated with Claude Code