Skip to content

fix: container name conflict #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxSiominDev merged 1 commit into from
Jun 1, 2026
+16 −1
Merged

fix: container name conflict #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...containers/src/main/java/org/testcontainers/containers/tarantool/Tarantool3Container.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,10 @@ protected void configure() {
withPrivilegedMode(true);
withCreateContainerCmdModifier(
cmd -> {
cmd.withName(this.node).withUser("root");
cmd.withUser("root");
if (cmd.getName() == null) {
cmd.withName(this.node);
}
Comment on lines +234 to +236
Copy link
Copy Markdown
Contributor

@ArtDu ArtDu Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess you can set name manually or if it's not then it's set as node?

But what is node? I don't want to search for meaning of node 😅

Copy link
Copy Markdown
Contributor Author

@MaxSiominDev MaxSiominDev Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node is just a name for a tarantool container instance

String[] originalEntrypoint =
Comment thread
MaxSiominDev marked this conversation as resolved.
cmd.getEntrypoint() != null && cmd.getEntrypoint().length > 0
? cmd.getEntrypoint()
Expand Down
12 changes: 12 additions & 0 deletions ...ners/src/test/java/org/testcontainers/containers/integration/tdb/TDB2ClusterImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,4 +394,16 @@ void testSimpleMultipleRestart() throws InterruptedException {
c.restart(1, TimeUnit.SECONDS);
}
}

@RepeatedTest(3)
void testSequentialClustersWithSameInstanceNamesDoNotConflict() {
for (int i = 0; i < 2; i++) {
try (TDBCluster c =
TDB2ClusterImpl.builder(TARANTOOL_DB_IMAGE_NAME)
.withStartupTimeout(STARTUP_TIMEOUT)
.build()) {
c.start();
}
}
}
}