fix: container name conflict#83
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Tarantool v3 Testcontainers implementation to avoid Docker container name collisions by no longer force-setting the container name during container creation.
Changes:
- Removed
cmd.withName(this.node)fromTarantool3Container.configure()so container names are not pinned to thenodevalue by default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Describe why you need it? what is purpose of change? what needs to make conflict? |
149d008 to
6b002a1
Compare
6b002a1 to
211caf5
Compare
I am trying to fix flaky tests (tntp-7314). As far as I understand, the underlying reason for the occasional failures is container name conflict. Original test randomizes container name using UUID, but here, the name is replaced and not random anymore. Hence we have confict, if old container is still running and new container is already started, they have the same name and tests fail due to docker error as it cannot run multiple containers with identical names at the same time |
I haven't forgotten about:
Related issues: