Skip to content

fix: container name conflict#83

Open
MaxSiominDev wants to merge 1 commit into
masterfrom
TNTP-7314-fix-container-name-conflict
Open

fix: container name conflict#83
MaxSiominDev wants to merge 1 commit into
masterfrom
TNTP-7314-fix-container-name-conflict

Conversation

@MaxSiominDev
Copy link
Copy Markdown

@MaxSiominDev MaxSiominDev commented May 27, 2026

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
    • JavaDoc was written
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

Copilot AI review requested due to automatic review settings May 27, 2026 21:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Tarantool v3 Testcontainers implementation to avoid Docker container name collisions by no longer force-setting the container name during container creation.

Changes:

  • Removed cmd.withName(this.node) from Tarantool3Container.configure() so container names are not pinned to the node value by default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ArtDu
Copy link
Copy Markdown
Contributor

ArtDu commented May 29, 2026

Describe why you need it? what is purpose of change? what needs to make conflict?

@ArtDu ArtDu requested review from ArtDu and nickkkccc May 29, 2026 07:16
@ArtDu ArtDu assigned MaxSiominDev and unassigned ArtDu and nickkkccc May 29, 2026
@MaxSiominDev MaxSiominDev force-pushed the TNTP-7314-fix-container-name-conflict branch from 149d008 to 6b002a1 Compare May 31, 2026 19:51
@MaxSiominDev MaxSiominDev force-pushed the TNTP-7314-fix-container-name-conflict branch from 6b002a1 to 211caf5 Compare May 31, 2026 19:56
@MaxSiominDev
Copy link
Copy Markdown
Author

Describe why you need it? what is purpose of change? what needs to make conflict?

I am trying to fix flaky tests (tntp-7314). As far as I understand, the underlying reason for the occasional failures is container name conflict. Original test randomizes container name using UUID, but here, the name is replaced and not random anymore. Hence we have confict, if old container is still running and new container is already started, they have the same name and tests fail due to docker error as it cannot run multiple containers with identical names at the same time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants