Skip attribute rules when framework class is missing + fix Rector skip path - #286
Merged
Merged
Conversation
…skip path for Rules/Enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow-ups to #285.
Do not require an attribute the project does not have
CommandMustHaveAsCommandAttributeRuleandConstraintMustHaveAttributeRulenow bail out early when the attribute/base class (AsCommand,Constraint) is not present in the analysed project. No false positive in a project that does not ship that Symfony component.Fix Rector skip path
rector.phpskippedStringClassNameToClassConstantRectorforsrc/Enum, but theSymfonyAttributevalue holder lives insrc/Rules/Enum. The path mismatch let Rector rewrite the intentional class-name strings to::class, which then broke on those classes not being loadable - that is what turned the Rector job red on main. Addedsrc/Rules/Enumto the skip list.Green locally: ECS, PHPStan, Rector, tests.