[symfony] Add NoServiceJugglingRule - #287
Merged
Merged
Conversation
… to another own method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
NoServiceJugglingRule.A service injected in
__construct()or anautowire*()method must not be handed over to another method call of the same class. Passing an own dependency around is service juggling - the service travels through a parameter list instead of being injected where it is used. When the called method belongs to the same class, it has a constructor of its own and can take the service directly.The rule is deliberately conservative:
autowire*(), or#[Required]) count,$thisand trait methods are shared by every child, so the service is a genuine argument there,Covered by
RuleTestCasewith report fixtures (promoted + autowired) and skip fixtures (value arg, own-parameter, trait method, varying argument, inherited method).Note: the Rector job may show one unrelated finding on
src/Rules/Enum/SymfonyAttribute.phpthat comes from main; it is fixed in #286.Green locally: ECS, PHPStan, Rector, composer-dependency-analyser, tests.