jextract/jni: Support enums that have no cases#577
Closed
sidepelican wants to merge 1 commit intoswiftlang:mainfrom
Closed
jextract/jni: Support enums that have no cases#577sidepelican wants to merge 1 commit intoswiftlang:mainfrom
sidepelican wants to merge 1 commit intoswiftlang:mainfrom
Conversation
ktoso
approved these changes
Feb 27, 2026
Collaborator
|
Thanks! |
sidepelican
commented
Feb 27, 2026
| let selfPointer = self.printSelfJLongToUnsafeMutablePointer( | ||
| &printer, | ||
| swiftParentName: type.swiftNominal.name, | ||
| swiftParentName: type.swiftNominal.qualifiedName, |
Contributor
Author
There was a problem hiding this comment.
I have found another problem again
error: cannot find type 'Nested' in scope
544 | assert(selfPointer != 0, "selfPointer memory address was null")
545 | let selfBits$ = Int(Int64(fromJNI: selfPointer, in: env$))
546 | guard let self$ = UnsafeMutablePointer<Nested>(bitPattern: selfBits$) else {
| `- error: cannot find type 'Nested' in scope
547 | fatalError("self memory address was null in call to \(#function)!")
548 | }
Collaborator
|
You know what, let's accept your other PR, it's simple enough. I don't think we need to over think this that much, not emitting the sealed interface will be fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the Swift enum has no cases, the generated Java code results in a compilation error.
In Swift, it is a common idiom to use enums with no cases as namespaces.
In cases where no enum cases exist, I will remove
sealedto ensure that no compilation errors occur.