jextract/jni: Skip discriminator generation if enum has no cases#573
Merged
ktoso merged 1 commit intoswiftlang:mainfrom Feb 27, 2026
Merged
jextract/jni: Skip discriminator generation if enum has no cases#573ktoso merged 1 commit intoswiftlang:mainfrom
ktoso merged 1 commit intoswiftlang:mainfrom
Conversation
ktoso
reviewed
Feb 27, 2026
Collaborator
ktoso
left a comment
There was a problem hiding this comment.
Hmmm, it may be better to emit but drop the "sealed" perhaps? Issues like "why didn't it get emitted" are annoying for users
Contributor
Author
|
Looks good, having fewer differences might be preferable. |
Collaborator
|
Thank you! |
Contributor
Author
|
New PR: #577 |
Collaborator
|
#577 faced some complications, so let's accept this one actually, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the Swift enum has no cases, the generated Java code results in a compilation error.
In Swift, it is a common idiom to use enums with no cases as namespaces.
I have updated the generator to skip the generation of any case-related code when an enum contains no cases.