Skip to content

fix(comment-preview-url): unbreak workflow validation #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick-hermann-sva merged 1 commit into from
May 19, 2026
Merged

fix(comment-preview-url): unbreak workflow validation #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/call-comment-preview-url.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,18 @@ on:
default: ""
type: string
description: |
Optional comma-separated `Label=URL` pairs to append as extra rows
Optional comma-separated Label=URL pairs to append as extra rows
in the comment table. Useful when the SUT's hostname isn't the
actual review surface — e.g. git-pitcher exposes only /health
and /metrics, but the events it produces are reviewed via a
co-tenanted core-catcher dashboard. The caller can interpolate
`${{ github.event.number }}` into the URL.
the PR number expression into the URL.

Example:
additional-urls: 'Dashboard=https://cc-git-pr-${{ github.event.number }}.homerun2-dev.example.com'
Example (caller-side, with PR-number interpolation rendered):
additional-urls: 'Dashboard=https://cc-git-pr-NUMBER.homerun2-dev.example.com'
Replace NUMBER with the standard github.event.number expression
on the caller side; embedding the raw expression here would be
evaluated at workflow-load time and break parsing.

permissions:
pull-requests: write
Expand Down