fix(comment-preview-url): unbreak workflow validation#93
Merged
patrick-hermann-sva merged 1 commit intoMay 19, 2026
Merged
Conversation
Commit 97ebd53 added an `additional-urls` input whose `description` block embedded a literal `${{ github.event.number }}` expression inside the example string. GitHub Actions evaluates `${{ }}` even inside `description:` text, and `github.event.number` isn't resolvable at workflow-load time — every caller of this reusable workflow has been failing with "This run likely failed because of a workflow file issue" since the merge of #92 on 2026-05-18T12:40Z. Confirmed broken on: - stuttgart-things/homerun2-git-pitcher (first failure 37s after #92) - stuttgart-things/homerun2-led-catcher (every run on its new PR workflow set since landing) Rewords the example to a placeholder (`NUMBER`) with a one-line note pointing the reader at the caller-side expression. Pure docs change; no behaviour change for callers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
patrick-hermann-sva
temporarily deployed
to
linting
GitHub Actions
Inactive
patrick-hermann-sva
temporarily deployed
to
linting
GitHub Actions
Inactive
patrick-hermann-sva
deleted the
fix/comment-preview-url-description-escape
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#92 added an
additional-urlsinput whosedescription:block embedded a literal\${{ github.event.number }}expression inside the example string. GitHub Actions evaluates\${{ }}even insidedescription:text, andgithub.event.numberisn't resolvable at workflow-load time — every caller of this reusable workflow has been failing with the generic "This run likely failed because of a workflow file issue" error since #92 merged on 2026-05-18T12:40Z.Impact (confirmed)
omni-pitcher,core-catcher,scout,demo-pitcher) will fail on their nextcomment-preview-urlinvocation until this lands.Fix
Rewords the example to use a
NUMBERplaceholder with a one-line note pointing readers at the caller-side expression form. Pure docs change; no behaviour change for callers.Test plan
actionlint/ GitHub schema validation)🤖 Generated with Claude Code