feat(comment-preview-url): support additional-urls for co-tenant review surfaces#92
Merged
patrick-hermann-sva merged 1 commit intoMay 18, 2026
Conversation
…view surfaces
Adds an optional `additional-urls` input that takes a comma-separated
list of `Label=URL` pairs and appends them as extra rows in the
preview comment table.
Motivated by stuttgart-things/homerun2-git-pitcher's PR-preview shape:
git-pitcher itself exposes only /health and /metrics, but the events
it produces are reviewed via a co-tenanted core-catcher dashboard at a
separate hostname. Without this, the preview comment only points at
git-pr-<num>.… (no UI) and reviewers have to guess at cc-git-pr-<num>.…
Existing callers (omni-pitcher, demo-pitcher, scout, core-catcher) are
unaffected — input defaults to empty string and the extra-rows block
collapses to nothing.
Caller usage:
additional-urls: 'Dashboard=https://cc-git-pr-${{ github.event.number }}.…'
Refs stuttgart-things/homerun2-git-pitcher#25
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
patrick-hermann-sva
temporarily deployed
to
linting
GitHub Actions
Inactive
patrick-hermann-sva
added a commit
to stuttgart-things/homerun2-git-pitcher
that referenced
this pull request
May 18, 2026
git-pitcher itself exposes only /health and /metrics — the actual review surface for a PR preview is the co-tenanted core-catcher dashboard. Pass cc-git-pr-<num>.… through the new additional-urls input on the comment-preview-url workflow template (stuttgart-things/github-workflow-templates#92). Refs #25 Co-authored-by: sthings user <sthings@dev-vm3.tiab.labda.sva.de> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 18, 2026
patrick-hermann-sva
added a commit
that referenced
this pull request
May 19, 2026
Commit 97ebd53 added an `additional-urls` input whose `description` block embedded a literal `${{ github.event.number }}` expression inside the example string. GitHub Actions evaluates `${{ }}` even inside `description:` text, and `github.event.number` isn't resolvable at workflow-load time — every caller of this reusable workflow has been failing with "This run likely failed because of a workflow file issue" since the merge of #92 on 2026-05-18T12:40Z. Confirmed broken on: - stuttgart-things/homerun2-git-pitcher (first failure 37s after #92) - stuttgart-things/homerun2-led-catcher (every run on its new PR workflow set since landing) Rewords the example to a placeholder (`NUMBER`) with a one-line note pointing the reader at the caller-side expression. Pure docs change; no behaviour change for callers. Co-authored-by: sthings user <sthings@dev-vm3.tiab.labda.sva.de> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
additional-urlsinput tocall-comment-preview-url.yaml, taking a comma-separated list ofLabel=URLpairs that get appended as extra rows in the preview comment table.Why
stuttgart-things/homerun2-git-pitcher's PR-preview shape (issue #25) puts the review surface on a co-tenanted workload, not on the SUT itself. git-pitcher exposes only/healthand/metricsatgit-pr-<num>.…; the events it produces are reviewed via a co-tenanted core-catcher dashboard atcc-git-pr-<num>.…. Without this input, the preview comment only points at the SUT hostname and reviewers have to guess at the dashboard URL.Caller usage
Result in the comment:
Compatibility
Existing callers (omni-pitcher, demo-pitcher, scout, core-catcher in this org) all pass nothing for
additional-urls— input defaults to""and the extra-rows block collapses to nothing. Pure addition, no behaviour change for them.Test plan
Refs stuttgart-things/homerun2-git-pitcher#25
🤖 Generated with Claude Code