Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions FULL_HELP_DOCS.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,16 +180,18 @@ Utilities to manage contract aliases

###### **Subcommands:**

- `remove` — Remove contract alias
- `rm` — Remove contract alias
- `add` — Add contract alias
- `show` — Show the contract id associated with a given alias
- `ls` — List all aliases

## `stellar contract alias remove`
## `stellar contract alias rm`

Remove contract alias

**Usage:** `stellar contract alias remove [OPTIONS] <ALIAS>`
**Usage:** `stellar contract alias rm [OPTIONS] <ALIAS>`

**Command Alias:** `remove`

###### **Arguments:**

Expand Down
31 changes: 31 additions & 0 deletions cmd/crates/soroban-test/tests/it/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,37 @@ fn can_remove_shadowed_native_alias() {
});
}

#[test]
fn alias_rm_is_canonical_with_remove_alias() {
TestEnv::with_default(|sandbox| {
sandbox
.new_assert_cmd("contract")
.args([
"alias",
"add",
"my-token",
"--id=CA3D5KRYM6CB7OWQ6TWYRR3Z4T7GNZLKERYNZGGA5SOAOPIFY6YQGAXE",
])
.assert()
.success();

// `rm` is the canonical subcommand name.
sandbox
.new_assert_cmd("contract")
.args(["alias", "rm", "my-token"])
.assert()
.success();

// `remove` still works as an alias.
sandbox
.new_assert_cmd("contract")
.args(["alias", "remove", "my-token"])
.assert()
.failure()
.stderr(predicate::str::contains("no contract found"));
});
}

#[test]
fn alias_ls_always_shows_builtin_native() {
TestEnv::with_default(|sandbox| {
Expand Down
9 changes: 5 additions & 4 deletions cmd/soroban-cli/src/commands/contract/alias.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@ use crate::commands::global;

pub mod add;
pub mod ls;
pub mod remove;
pub mod rm;
pub mod show;

#[derive(Debug, clap::Subcommand)]
pub enum Cmd {
/// Remove contract alias
Remove(remove::Cmd),
#[command(visible_alias = "remove")]
Rm(rm::Cmd),

/// Add contract alias
Add(add::Cmd),
Expand All @@ -23,7 +24,7 @@ pub enum Cmd {
#[derive(thiserror::Error, Debug)]
pub enum Error {
#[error(transparent)]
Remove(#[from] remove::Error),
Rm(#[from] rm::Error),

#[error(transparent)]
Add(#[from] add::Error),
Expand All @@ -38,7 +39,7 @@ pub enum Error {
impl Cmd {
pub fn run(&self, global_args: &global::Args) -> Result<(), Error> {
match &self {
Cmd::Remove(remove) => remove.run(global_args)?,
Cmd::Rm(rm) => rm.run(global_args)?,
Cmd::Add(add) => add.run(global_args)?,
Cmd::Show(show) => show.run(global_args)?,
Cmd::Ls(ls) => ls.run()?,
Expand Down
Loading