Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a non-blocking test-name nit remains; no approval-blocking issues were identified.
Pull request overview
Renames stellar contract alias remove to canonical rm while retaining remove as a compatibility alias.
Changes:
- Renames command implementation and wiring.
- Updates help documentation.
- Adds integration coverage for both spellings.
File summaries
| File | Summary |
|---|---|
FULL_HELP_DOCS.md |
Documents rm and its remove alias. |
cmd/soroban-cli/src/commands/contract/alias/rm.rs |
Implements alias removal. |
cmd/soroban-cli/src/commands/contract/alias.rs |
Registers the canonical command and compatibility alias. |
cmd/crates/soroban-test/tests/it/config.rs |
Tests both command spellings; minor test-name nit noted. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
approved these changes
Sep 17, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A runtime diagnostic still recommends the legacy remove spelling instead of canonical rm.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 1
- Review effort level: Balanced
| pub enum Cmd { | ||
| /// Remove contract alias | ||
| Remove(remove::Cmd), | ||
| #[command(visible_alias = "remove")] |
Contributor
|
@fnando and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the
stellar contract alias removesubcommand tostellar contract alias rm, withremovekept as a visible alias for backwards compatibility.Why
Other CLI commands that delete things use
rmas the canonical subcommand (stellar keys rm,stellar network rm);contract aliaswas the odd one out withremove. This makes the naming consistent while keeping the oldremovespelling working.