test: migrate stats/incr/nanmrss to ULP-based assertions - #15166
Merged
Conversation
Migrate the tolerance-based assertion in `stats/incr/nanmrss` tests from a computed relative tolerance to a ULP-difference assertion using `@stdlib/assert/is-almost-same-value`. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014muLqDv12CgWqs2cpTH9vW --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/nanmrssfrom a computed relative-tolerance comparison (delta = abs( expected - actual )/tol = 1.0 * EPS * abs( expected ), asserted viat.equal( delta <= tol, ... )) to a ULP-difference assertion using@stdlib/assert/is-almost-same-value.test/test.js. The package has notest/test.native.js. The remaining assertions in the file are exact comparisons againstnull, thrownTypeErrors, function types, and the exactly representable value145.0, which are correct as-is and are left unchanged.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with thedeltaandtolvariable declarations.if ( actual === expected[i] ) { ... } else { ... }branch in the moving-residual-sum-of-squares test into a single ULP assertion, matching the migrated idiom.Only a test file is changed; no implementation, fixture, or documentation changes are included.
ULP bounds
1.0 * EPS * abs( expected )0This is the minimum integer bound
Nsuch thatisAlmostSameValue( actual, expected[ i ], N )holds at the assertion site, and it is the floor of the scale — no tighter bound exists. It was measured independently of the test harness by computingulpDifference( actual, expected[ i ] )directly at every element, starting from a high bound (64, which passes) and tightening.The per-element ULP differences are
0, 0, 0, 0, 0, 0, 0, 0, 0: the accumulator reproduces every expected value (1,1,1,17,26,89,89,82,154) bit-for-bit. These are small integers well within the exactly representable range, and the incremental algorithm accumulates only sums of products of small integer-valued inputs, so no rounding occurs at any step. The original test anticipated this by branching onactual === expected[i]and taking the exact-comparison path first; the pre-existing relative tolerance was never actually exercised on this platform. AtN = 0,isAlmostSameValuedelegates toisSameValue, so the migrated assertion preserves that exact-comparison behavior rather than loosening it.make test TESTS_FILTER=".*/stats/incr/nanmrss/.*"was run twice at the final bound with identical results: 25/25 passing on both runs, no failures, ruling out FMA/architecture-dependent flakiness on this platform.make eslint-tests TESTS_FILTER=".*/stats/incr/nanmrss/.*"is clean.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
The migrated bound is
0rather than1. Since every value in this fixture is exact,0is the minimum required bound as the tracking issue asks for, and it preserves the exact comparison the original test already performed via itsactual === expected[i]branch. A bound of1would be strictly weaker than the assertion being replaced. Flagging in case a reviewer would prefer1for consistency with sibling packages whose fixtures are genuinely inexact;0is used elsewhere in the migrated set, so this follows existing precedent.Other
The resulting diff mirrors the already-merged migrations for the sibling accumulator packages
stats/incr/nanmhmean(#15125),stats/incr/mmape(#15150), andstats/incr/mda(#15142), which share the same test structure.One environment note, which did not affect verification:
make install-node-modulesinitially failed withETARGETfores-object-atoms@^1.1.2. As previously observed in #15116 and #15125, this is a stale local npm packument cache rather than a repository or registry problem; refetching withnpm_config_prefer_online=truesucceeded, after whichmake initand the full toolchain were available for this PR.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as an unattended scheduled task. It selected the package, studied previously migrated packages in the same family to match the established idiom, performed the migration, and determined the minimum passing ULP bound empirically at the assertion site.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_014muLqDv12CgWqs2cpTH9vW
Generated by Claude Code