Skip to content

test: migrate stats/incr/mmeanabs2 to ULP-based assertions - #15171

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-mmeanabs2
Sep 12, 2026
Merged

test: migrate stats/incr/mmeanabs2 to ULP-based assertions#15171
kgryte merged 1 commit into
developfrom
kgryte/ulp-mmeanabs2

Conversation

@kgryte

@kgryte kgryte commented Sep 11, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the tests for stats/incr/mmeanabs2 from a computed relative-tolerance comparison (delta = abs( expected - actual ) / tol = 1.0 * EPS * abs( expected ), asserted via t.strictEqual( delta <= tol, ... )) to a ULP-difference assertion using @stdlib/assert/is-almost-same-value.
  • applies the migration to the single tolerance-based assertion site in test/test.js. The package has no test/test.native.js. The remaining assertions in the file are exact comparisons against null, thrown TypeErrors, function types, NaN, and the exactly representable values 17.0 and 9.8596, which are correct as-is and are left unchanged.
  • removes the now-unused @stdlib/math/base/special/abs and @stdlib/constants/float64/eps requires, along with the delta and tol variable declarations.
  • collapses the if ( actual === expected[i] ) { ... } else { ... } branch in the moving-mean-of-squared-absolute-values test into a single ULP assertion, matching the migrated idiom.

Only a test file is changed; no implementation, fixture, or documentation changes are included.

ULP bounds

Assertion Previous tolerance ULP bound
moving arithmetic mean of squared absolute values computed incrementally (6 values) 1.0 * EPS * abs( expected ) 1

This is the minimum integer bound N such that isAlmostSameValue( actual, expected[ i ], N ) holds at every element of the fixture. It was measured by starting from a high bound (64, which passes) and tightening, computing the per-element ULP distance directly outside the test harness and then confirming through the test suite: at N = 1 the suite is 41/41 passing, and at N = 0 three assertions fail (38/41), so no tighter bound exists.

The per-element ULP differences are 0, 0, 0, 1, 1, 1. The first three expected values (4.0, 6.5, 17.0/3.0) are reproduced bit-for-bit, while the last three (29.0/3.0, 29.0/3.0, 41.0/3.0) differ by one ULP: the accumulator computes the window mean incrementally rather than as a single division, so it returns 9.666666666666668 where the literal expression 29.0/3.0 rounds to 9.666666666666666. The original test anticipated this by branching on actual === expected[i] and falling back to a relative tolerance for the inexact cases.

make test TESTS_FILTER=".*/stats/incr/mmeanabs2/.*" was run twice at the final bound with identical results: 41/41 passing on both runs, no failures, ruling out FMA/architecture-dependent flakiness on this platform. make eslint-tests TESTS_FILTER=".*/stats/incr/mmeanabs2/.*" is clean.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The resulting diff mirrors the already-merged migrations for the sibling accumulator packages stats/incr/mmape (#15150), stats/incr/mda (#15142), and stats/incr/nanmrss (#15166), which share the same test structure.

Two environment notes, neither of which affected verification:

  • make install-node-modules initially failed with ETARGET for es-object-atoms@^1.1.2. The version does exist in the registry (published 2026-05-22); the local npm packument cache was stale and served a filtered view. After npm cache clean --force, the install completed and the full toolchain was available for this PR.
  • The pre-commit hook's lint-editorconfig-files step could not run, because it downloads the editorconfig-checker binary from a GitHub release that this environment cannot reach. The changed file was instead checked manually against .editorconfig: LF line endings, tab indentation, no trailing whitespace, and a final newline.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code, running as an unattended scheduled task. It selected the package, studied previously migrated packages in the same family to match the established idiom, performed the migration, and determined the minimum passing ULP bound empirically at the assertion site.


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_01JhctBo3ZhP4kbZgXCWBZ7a


Generated by Claude Code

Migrate the tests for `stats/incr/mmeanabs2` from a computed relative
tolerance comparison to a ULP difference assertion using
`@stdlib/assert/is-almost-same-value`. The measured minimum ULP bound
is 1.

Ref: #11352

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JhctBo3ZhP4kbZgXCWBZ7a
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Sep 11, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/mmeanabs2 $\\color{green}141/141$
$\\color{green}+100.00\\%$
$\\color{green}8/8$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}141/141$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review September 12, 2026 07:42
@kgryte
kgryte requested a review from a team September 12, 2026 07:42
@kgryte kgryte added the Tests Pull requests specifically adding tests. label Sep 12, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 12, 2026
@kgryte
kgryte merged commit c88d3f4 into develop Sep 12, 2026
82 checks passed
@kgryte
kgryte deleted the kgryte/ulp-mmeanabs2 branch September 12, 2026 07:43
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants