Skip to content

fix: fortran benchmark build of blas/base/dger #11333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DhruvArvindSingh wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −1
Open

fix: fortran benchmark build of blas/base/dger #11333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/base/dger/benchmark/fortran/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ endif
INCLUDE ?=

# List of Fortran source files:
SOURCE_FILES ?= ../../src/dger.f
SOURCE_FILES ?= ../../src/dger.f ../../../xerbla/src/xerbla.f
Copy link
Copy Markdown
Member

@kgryte kgryte Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what we want to do. We shouldn't be hardcoding paths of dependencies. This is explicitly what we want to avoid and is why we have dynamic dependency resolution via the manifest.json.


# List of Fortran targets:
f_targets := benchmark.length.out
Expand Down