Skip to content

fix: fortran benchmark build of blas/base/dger#11333

Open
DhruvArvindSingh wants to merge 1 commit intostdlib-js:developfrom
DhruvArvindSingh:fix/blas/base/dger
Open

fix: fortran benchmark build of blas/base/dger#11333
DhruvArvindSingh wants to merge 1 commit intostdlib-js:developfrom
DhruvArvindSingh:fix/blas/base/dger

Conversation

@DhruvArvindSingh
Copy link
Copy Markdown
Contributor

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes Fortran benchmark build error by adding dependency location in the Makefile.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Apr 8, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/dger $\color{green}715/715$
$\color{green}+100.00%$
$\color{green}84/84$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}715/715$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@DhruvArvindSingh
Copy link
Copy Markdown
Contributor Author

dhruv  stdlib ➜ make benchmark-fortran-files FILES="$(pwd)/lib/node_modules/@stdlib/blas/base/dger/benchmark/fortran/benchmark.length.f"

Running benchmark: /home/dhruv/C_drive/Open_Source/stdlib/lib/node_modules/@stdlib/blas/base/dger/benchmark/fortran/benchmark.length.f
make[1]: Entering directory '/home/dhruv/C_drive/Open_Source/stdlib/lib/node_modules/@stdlib/blas/base/dger/benchmark/fortran'
make[1]: Leaving directory '/home/dhruv/C_drive/Open_Source/stdlib/lib/node_modules/@stdlib/blas/base/dger/benchmark/fortran'
Resolving package path...
Package path: /home/dhruv/C_drive/Open_Source/stdlib/lib/node_modules/@stdlib/blas/base/dger
Resolving package manifest...
Successfully resolved package manifest.
Resolving include directories...
Compiling benchmark...
make[1]: Entering directory '/home/dhruv/C_drive/Open_Source/stdlib/lib/node_modules/@stdlib/blas/base/dger/benchmark/fortran'
/usr/bin/ld: /tmp/ccr3NTeD.o: in function `dger':
dger.f:(.text+0x21b): undefined reference to `xerbla'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:119: benchmark.length.out] Error 1
make[1]: Leaving directory '/home/dhruv/C_drive/Open_Source/stdlib/lib/node_modules/@stdlib/blas/base/dger/benchmark/fortran'
Error when attempting to compile benchmark.
ERROR: An error was encountered during execution.

make: *** [/home/dhruv/C_drive/Open_Source/stdlib/tools/make/lib/benchmark/fortran.mk:76: benchmark-fortran-files] Error 1

I was getting the following build error, which got solved once i included the dependencies location within the MakeFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants