Skip to content

Refactor SDK metrics: rename metrics from cloud_provider_stackit_http* to stackit_api_http.* - #1516

Merged
ske-prow[bot] merged 3 commits into
mainfrom
refactorSDKMetrics
Aug 21, 2026
Merged

Refactor SDK metrics: rename metrics from cloud_provider_stackit_http* to stackit_api_http.*#1516
ske-prow[bot] merged 3 commits into
mainfrom
refactorSDKMetrics

Conversation

@dergeberl

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement
/cc @stackitcloud/ske-infrastructure

What this PR does / why we need it:
This PR will change the metrics from cloud_provider_stackit_http.* to stackit_api_http.*.
The metrics do not contain an API label anymore which needed to be configured. They now contain the host of the API which contains the same information. Also the op labe was renamed to operation label and now contains the function name from the SDK. It also contains a component which can be different within the same repo, like cloud-controller-manager and stackit-csi-plugin.

The metrics package can be used the same way also in other repos later like application-load-balancer-controller.

Special notes for your reviewer:

Breaking changes:
/label breaking
Rename of metrics cloud_provider_stackit_http.* to stackit_api_http.*.
Different labels on the metrics (host instead of api and operation instead of op)

@ske-prow
ske-prow Bot requested a review from a team August 20, 2026 14:08
@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension breaking This PR contains a breaking change and should be listed accordingly in release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2026
Comment thread pkg/metrics/metrics.go
@dergeberl

Copy link
Copy Markdown
Member Author

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

@stackit-ske

Copy link
Copy Markdown

@dergeberl: once the present PR merges, I will cherry-pick it on top of release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread pkg/metrics/http.go
Comment thread pkg/metrics/http.go Outdated
Comment thread pkg/metrics/http.go Outdated
@ske-prow

ske-prow Bot commented Aug 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breuerfelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2026
@ske-prow

ske-prow Bot commented Aug 21, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: e66824f2ebad700d8fbd00348c642b6e4221670d

@ske-prow
ske-prow Bot merged commit 017b2bb into main Aug 21, 2026
3 checks passed
@ske-prow
ske-prow Bot deleted the refactorSDKMetrics branch August 21, 2026 13:20
@stackit-ske

Copy link
Copy Markdown

@dergeberl: new pull request created: #1531

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske

Copy link
Copy Markdown

@dergeberl: new pull request created: #1532

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske

Copy link
Copy Markdown

@dergeberl: new pull request created: #1533

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. breaking This PR contains a breaking change and should be listed accordingly in release notes. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants