Refactor SDK metrics: rename metrics from cloud_provider_stackit_http* to stackit_api_http.* - #1516
Conversation
72819b7 to
b90267e
Compare
|
/cherry-pick release-v1.34 |
|
@dergeberl: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breuerfelix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: e66824f2ebad700d8fbd00348c642b6e4221670d |
|
@dergeberl: new pull request created: #1531 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1532 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1533 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
How to categorize this PR?
/kind enhancement
/cc @stackitcloud/ske-infrastructure
What this PR does / why we need it:
This PR will change the metrics from
cloud_provider_stackit_http.*tostackit_api_http.*.The metrics do not contain an API label anymore which needed to be configured. They now contain the host of the API which contains the same information. Also the
oplabe was renamed tooperationlabel and now contains the function name from the SDK. It also contains a component which can be different within the same repo, likecloud-controller-managerandstackit-csi-plugin.The metrics package can be used the same way also in other repos later like
application-load-balancer-controller.Special notes for your reviewer:
Breaking changes:
/label breaking
Rename of metrics
cloud_provider_stackit_http.*tostackit_api_http.*.Different labels on the metrics (
hostinstead ofapiandoperationinstead ofop)