Add metrics for API calls - #261
Merged
Merged
Conversation
ske-prow
Bot
added
do-not-merge/hold
dergeberl
force-pushed
the
addMetricsForAPICalls
branch
from
August 21, 2026 13:16
bb75fe1 to
c3e0d26
Compare
ske-prow
Bot
removed
the
needs-rebase
Member
Author
|
/unhold |
ske-prow
Bot
removed
the
do-not-merge/hold
xoxys
approved these changes
Aug 21, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xoxys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
approved
|
LGTM label has been added. DetailsGit tree hash: 6641bf66c44650d0275b639569865db5282d7f6b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR adds metrics for API calls. Similar to the metrics in
cloud-provider-stackitsee https://github.com/stackitcloud/cloud-provider-stackit/tree/main/pkg/metricsOnly the tests are adopted to not add additional SDK dependencies.
Special notes for your reviewer:
/hold
As there is still an open PR for the
cloud-provider-stackitstackitcloud/cloud-provider-stackit#1516