Switch to CentOS Stream 10 IPA images on Rocky 10 - #2486
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughUpdate Rocky Linux 10 configuration to use CentOS Stream 10 IPA images. Add Rocky Linux 10 image build and promotion workflows, Pulp version tags, and separate Rocky Linux 9 and 10 image selection. Document upstream support for building these images. WalkthroughThe workflows now build and promote Rocky Linux 10 IPA images for x86_64 and aarch64. Kayobe configuration selects release- and architecture-specific image versions and URLs. A release note documents CentOS Stream 10 image support. ChangesRocky Linux 10 IPA image pipeline
Estimated code review effort: 3 (Moderate) | ~30 minutes Sequence Diagram(s)sequenceDiagram
participant BuildWorkflow as ipa-image-build.yml
participant X86Builder as x86_64 builder
participant ArmBuilder as aarch64 builder
participant ImageRepository as IPA image repository
BuildWorkflow->>X86Builder: Build Rocky Linux 10 x86_64 image
BuildWorkflow->>ArmBuilder: Build Rocky Linux 10 aarch64 image
X86Builder->>ImageRepository: Upload kernel and ramdisk artifacts
ArmBuilder->>ImageRepository: Upload kernel and ramdisk artifacts
BuildWorkflow->>BuildWorkflow: Report build failures and collect logs
Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7e905c06-9ab3-43b4-b6c8-cff275c4d78a
📒 Files selected for processing (5)
.github/workflows/ipa-image-build.yml.github/workflows/ipa-image-promote.ymletc/kayobe/pulp-ipa-image-versions.ymletc/kayobe/stackhpc-ipa-images.ymlreleasenotes/notes/centos-stream-10-ipa-dde5cf23f432b541.yaml
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: stackhpc/check
- GitHub Check: Ansible 2.17 lint with Python 3.10
- GitHub Check: Ansible 2.18 lint with Python 3.12
🧰 Additional context used
🪛 zizmor (1.29.0)
.github/workflows/ipa-image-promote.yml
[warning] 41-41: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 42-42: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 43-43: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 44-44: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 45-45: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 139-139: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 140-140: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
.github/workflows/ipa-image-build.yml
[warning] 68-68: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 69-69: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 70-70: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 71-71: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 72-72: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 79-79: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 79-79: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 80-80: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 420-420: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 436-436: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 736-736: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 737-737: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 738-738: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 754-754: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 755-755: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 756-756: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
🔇 Additional comments (6)
.github/workflows/ipa-image-promote.yml (3)
14-21: LGTM!
119-138: LGTM!Also applies to: 141-145
43-44: 🔒 Security & PrivacyKeep dispatch inputs out of shell source.
Direct interpolation permits shell expansion. Pass
rocky10androcky10-aarch64throughenvbefore comparison. GitHub documentation does not establish whether the dispatch API rejects arbitrary strings, so confirm this validation behaviour.etc/kayobe/pulp-ipa-image-versions.yml (1)
5-6: 🗄️ Data Integrity & IntegrationVerify the Rocky Linux 10 image tags before deployment.
Lines 5-6 hard-code
2025.1-20260805T091024, while the build workflow publishes withneeds.create-tag.outputs.ipa_image_tag. Confirm that the output matches this value and that bothrocky/10androcky/10/aarch64Pulp paths are promoted. Otherwise,etc/kayobe/stackhpc-ipa-images.ymlLines 17-20 can resolve to missing image URLs.etc/kayobe/stackhpc-ipa-images.yml (1)
17-20: LGTM!Also applies to: 23-28
releasenotes/notes/centos-stream-10-ipa-dde5cf23f432b541.yaml (1)
1-6: LGTM!
Odd. Might just be zuul having a funny 5 |
|
recheck merge failed |
CentOS Stream 10 IPA images are now working - image building workflow has been updated to enable building images and pulp tags and IPA pulp tag selection updated to make use of these new images rather than CentOS Stream 9 images as are currently used. IPA images built on Rocky 10 are still a WIP - ironic-python-agent-builder doesn't support yet.
442347c to
bfd587f
Compare
CentOS Stream 10 IPA images are now working - image building workflow has been updated to enable building images and pulp tags and IPA pulp tag selection updated to make use of these new images rather than CentOS Stream 9 images as are currently used.
IPA images built on Rocky 10 are still a WIP - ironic-python-agent-builder doesn't support yet.