2026.1: Purge references to RL9 from GH workflow files - #2458
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThe workflows replace Rocky Linux 9 selections, build paths, promotion paths, upload paths, and matrix entries with Rocky Linux 10 equivalents. Ubuntu Noble remains where supported. The Kolla ChangesRocky Linux 10 transition
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/update-overcloud-host-image-tags.yml:
- Line 54: Update the checkout step in the workflow to use the invoking branch
via github.ref_name instead of the hardcoded stackhpc/2025.1 ref, while leaving
the generated branch name based on the existing image-tag inputs unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 90c47f14-0403-428c-858d-d09e8fdd7d3f
📒 Files selected for processing (13)
.github/workflows/ipa-image-build.yml.github/workflows/ipa-image-promote.yml.github/workflows/overcloud-host-image-build.yml.github/workflows/overcloud-host-image-promote.yml.github/workflows/overcloud-host-image-upload.yml.github/workflows/package-build-ofed.yml.github/workflows/stackhpc-build-kayobe-image.yml.github/workflows/stackhpc-container-image-build.yml.github/workflows/stackhpc-multinode.yml.github/workflows/stackhpc-update-kolla.yml.github/workflows/trigger-overcloud-host-image-build.yml.github/workflows/update-dependencies.yml.github/workflows/update-overcloud-host-image-tags.yml
9716ecb to
00d13ae
Compare
6c63400 to
7fd3f19
Compare
|
Rebased due to conflicts |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ipa-image-build.yml:
- Around line 305-306: Update both Rocky Linux 10 build blocks in the workflow
to pass ipa_build_distro as "rocky" and ipa_build_release as "10" instead of the
current CentOS and 10-stream values, keeping the existing upload artifact labels
consistent.
In @.github/workflows/ipa-image-promote.yml:
- Around line 98-99: Harden the promote workflow’s openstack_release handling
around the repository_name and pulp_base_path arguments: restrict
workflow_dispatch refs to trusted branches, validate the checkout-derived
openstack_release against the expected release format, and pass it through the
step’s env rather than interpolating it directly into shell arguments. Preserve
the existing Rocky 10 aarch64 naming and path behavior after validation.
In @.github/workflows/update-overcloud-host-image-tags.yml:
- Around line 31-32: Extend the update workflow around the Rocky 10 host image
tag step to also update the Rocky Linux 9 image tag keys consumed by
stackhpc-all-in-one.yml and multinode-inputs.py. Preserve the existing Rocky 10
update behavior and ensure both Rocky versions receive refreshed tags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e83a6013-f19a-4be1-b058-29165f0eba67
📒 Files selected for processing (11)
.github/workflows/ipa-image-build.yml.github/workflows/ipa-image-promote.yml.github/workflows/overcloud-host-image-build.yml.github/workflows/overcloud-host-image-promote.yml.github/workflows/overcloud-host-image-upload.yml.github/workflows/package-build-ofed.yml.github/workflows/stackhpc-build-kayobe-image.yml.github/workflows/stackhpc-container-image-build.yml.github/workflows/stackhpc-multinode.yml.github/workflows/stackhpc-update-kolla.yml.github/workflows/update-overcloud-host-image-tags.yml
🚧 Files skipped from review as they are similar to previous changes (8)
- .github/workflows/stackhpc-multinode.yml
- .github/workflows/package-build-ofed.yml
- .github/workflows/overcloud-host-image-upload.yml
- .github/workflows/stackhpc-update-kolla.yml
- .github/workflows/stackhpc-build-kayobe-image.yml
- .github/workflows/stackhpc-container-image-build.yml
- .github/workflows/overcloud-host-image-promote.yml
- .github/workflows/overcloud-host-image-build.yml
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ipa-image-build.yml (1)
317-377: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winRemove the duplicate Rocky 10 workflow blocks.
Each build job defines its Rocky 10 step ID twice. GitHub Actions rejects duplicate step IDs within a job.
- Remove one x86_64 block at
.github/workflows/ipa-image-build.ymllines 317–377 or 379–439.- Remove one aarch64 block at lines 626–691 or 693–758.
- Remove one copy of each Rocky 10 promotion step at
.github/workflows/ipa-image-promote.ymllines 82–107 or 109–134.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ipa-image-build.yml around lines 317 - 377, Remove one duplicate Rocky 10 workflow block in each affected location: .github/workflows/ipa-image-build.yml lines 317-377 (or its duplicate at 379-439), .github/workflows/ipa-image-build.yml lines 626-691 (or 693-758), and .github/workflows/ipa-image-promote.yml lines 82-107 (or 109-134). Preserve one complete block per architecture and one Rocky 10 promotion block, including its unique step IDs, so each job has no duplicate step IDs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/ipa-image-build.yml:
- Around line 317-377: Remove one duplicate Rocky 10 workflow block in each
affected location: .github/workflows/ipa-image-build.yml lines 317-377 (or its
duplicate at 379-439), .github/workflows/ipa-image-build.yml lines 626-691 (or
693-758), and .github/workflows/ipa-image-promote.yml lines 82-107 (or 109-134).
Preserve one complete block per architecture and one Rocky 10 promotion block,
including its unique step IDs, so each job has no duplicate step IDs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: db26689b-50ab-474a-9ee0-2d085256d563
📒 Files selected for processing (11)
.github/workflows/ipa-image-build.yml.github/workflows/ipa-image-promote.yml.github/workflows/overcloud-host-image-build.yml.github/workflows/overcloud-host-image-promote.yml.github/workflows/overcloud-host-image-upload.yml.github/workflows/package-build-ofed.yml.github/workflows/stackhpc-build-kayobe-image.yml.github/workflows/stackhpc-container-image-build.yml.github/workflows/stackhpc-multinode.yml.github/workflows/stackhpc-update-kolla.yml.github/workflows/update-overcloud-host-image-tags.yml
🚧 Files skipped from review as they are similar to previous changes (8)
- .github/workflows/stackhpc-build-kayobe-image.yml
- .github/workflows/stackhpc-update-kolla.yml
- .github/workflows/overcloud-host-image-upload.yml
- .github/workflows/stackhpc-container-image-build.yml
- .github/workflows/update-overcloud-host-image-tags.yml
- .github/workflows/stackhpc-multinode.yml
- .github/workflows/overcloud-host-image-build.yml
- .github/workflows/package-build-ofed.yml
Removes all references to RL9 from GitHub workflow files in the repo, and where appropriate, replaces them with RL10
3 participants
Removes all references to RL9 from GitHub workflow files in the repo, and where appropriate, replaces them with RL10
I also removed a few 2025.1 references while I was there, but that's largely out of scope for this PR. I'll go through again in the future to check them properly
Summary by CodeRabbit