Skip to content

feat(versioned): Support conversion tracking through enums - #1294

Open
sbernauer wants to merge 1 commit into
feat/from_docsfrom
feat/track-enums
Open

sbernauer wants to merge 1 commit into
feat/from_docsfrom
feat/track-enums

Conversation

@sbernauer

Copy link
Copy Markdown
Member

Description

Builds on top of #1293!

With experimental_conversion_tracking enabled, versioned enums now implement TrackingFrom instead of From, in line with structs.

Also fix the generated From impls for variants with multiple unnamed fields, which were missing separating commas.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

With experimental_conversion_tracking enabled, versioned enums now implement
TrackingFrom instead of From, in line with structs. Variants marked with
as an additional path segment (eg. `$.connector.Iceberg.field`).

Also fix the generated From impls for variants with multiple unnamed fields,
which were missing separating commas.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@sbernauer
sbernauer added this pull request to stack #1295 October 9, 2026 14:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant