Skip to content

feat(versioned): Roundtrip-track changed types - #1296

Open
sbernauer wants to merge 2 commits into
feat/track-enumsfrom
feat/track-changed-types
Open

sbernauer wants to merge 2 commits into
feat/track-enumsfrom
feat/track-changed-types

Conversation

@sbernauer

Copy link
Copy Markdown
Member

Description

Builds on top of #1294

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

sbernauer and others added 2 commits October 9, 2026 16:07
Tracked values were stored as serde_yaml::Value, which represents enum
variants as YAML tags. After a roundtrip through the JSON status, these could
not be deserialized again, which panicked during the upgrade. The status is
stored as JSON anyway, so values are now tracked as serde_json::Value.

Also fix restoring type changes whose downgraded value is null: it is
serialized as `downgradedValue: null` and deserialized as None, so the
comparison never matched. A missing downgraded value is now treated as null.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@sbernauer
sbernauer added this pull request to stack #1295 October 9, 2026 14:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant