Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stale-dolls-shave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@slack/cli-hooks": patch
---

fix: use correct bolt-js release notes tag format
2 changes: 1 addition & 1 deletion packages/cli-hooks/src/check-update.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ async function fetchLatestPackageVersion(packageName) {
*/
function getReleaseNotesUrl(packageName, latestVersion) {
if (packageName === SLACK_BOLT_SDK) {
return `https://github.com/slackapi/bolt-js/releases/tag/@slack/bolt@${latestVersion}`;
return `https://github.com/slackapi/bolt-js/releases/tag/v${latestVersion}`;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 note: Our latest releases now keep a shortened tag. IMHO we can ignore earlier formatting unless this changes again since release notifications appear with latest versions and not prior updates?

📚 https://github.com/slackapi/bolt-js/releases/tag/v4.7.2

}
if (packageName === SLACK_CLI_HOOKS) {
return `https://github.com/slackapi/node-slack-sdk/releases/tag/@slack/cli-hooks@${latestVersion}`;
Expand Down
6 changes: 3 additions & 3 deletions packages/cli-hooks/src/check-update.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ describe('check-update implementation', async () => {
releases: [
{
name: '@slack/bolt',
current: '3.0.0',
latest: '3.1.4',
current: '4.0.0',
latest: '4.7.2',
error: undefined,
update: true,
message: undefined,
breaking: false,
url: 'https://github.com/slackapi/bolt-js/releases/tag/@slack/bolt@3.1.4',
url: 'https://github.com/slackapi/bolt-js/releases/tag/v4.7.2',
},
{
name: '@slack/cli-hooks',
Expand Down
Loading